Skip to content

Viz: reuse Coords, Size and BBox and type locals instead of @ts-expect-error - #36409

Open
EugeniyKiyashko wants to merge 1 commit into
DevExpress:26_1from
EugeniyKiyashko:viz-return-type-review-26_1
Open

EugeniyKiyashko wants to merge 1 commit into
DevExpress:26_1from
EugeniyKiyashko:viz-return-type-review-26_1

Conversation

@EugeniyKiyashko

Copy link
Copy Markdown
Contributor

No description provided.

…t-error

Replaces the remaining inline { x; y }, { width; height } and
{ x; y; width; height } types in js/__internal/viz with Coords, Size
and BBox from viz/core/types.ts.

Gives an explicit type to locals that start as null, [] or a narrower
value and are reassigned later, and removes the 22 @ts-expect-error
directives that only covered those reassignments. Emitted JS is unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant