Skip to content

Viz: type sparklines, range_selector and gauges - #36410

Open
EugeniyKiyashko wants to merge 2 commits into
DevExpress:mainfrom
EugeniyKiyashko:viz-typing-folders
Open

EugeniyKiyashko wants to merge 2 commits into
DevExpress:mainfrom
EugeniyKiyashko:viz-typing-folders

Conversation

@EugeniyKiyashko

Copy link
Copy Markdown
Contributor

No description provided.

Removes the typing disables of the three folders: no-unsafe-return,
no-unsafe-declaration-merging and explicit-module-boundary-types.

- Plugin members are declared in the class with `declare` instead of a
  same-named interface merged into it.
- Gauge elements, indicators and the range container get their real
  types; _createIndicator has strict and non-strict overloads.
- formatValue, the axis method proxy, the selected range, the tracker
  events and convertVisualRangeObject get types.

The only JS change: isTouchEventArgs uses startsWith('touch') instead of
indexOf('touch') === 0, which is the same for strings.
@EugeniyKiyashko
EugeniyKiyashko requested a review from a team as a code owner November 18, 2026 19:24
@EugeniyKiyashko EugeniyKiyashko self-assigned this Nov 18, 2026
Removes the no-plusplus, no-nested-ternary, no-multi-assign,
no-param-reassign, no-else-return, no-shadow and no-unused-expressions
disables from range_selector with equivalent rewrites:
- i++ / x++ statements become += 1 (the values are numbers);
- chained assignments to plain fields and locals become two statements,
  inner target first;
- nested ternaries become if/else that evaluate the same branch;
- reassigned parameters become new locals;
- `a && b()` statements become if statements.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant