Repository navigation
Viz: type sparklines, range_selector and gauges - #36412
Open
EugeniyKiyashko wants to merge 2 commits into
Open
EugeniyKiyashko wants to merge 2 commits into
EugeniyKiyashko wants to merge 2 commits into
Conversation
Removes the typing disables of the three folders: no-unsafe-return,
no-unsafe-declaration-merging and explicit-module-boundary-types.
- Plugin members are declared in the class with `declare` instead of a
same-named interface merged into it.
- Gauge elements, indicators and the range container get their real
types; _createIndicator has strict and non-strict overloads.
- formatValue, the axis method proxy, the selected range, the tracker
events and convertVisualRangeObject get types.
The only JS change: isTouchEventArgs uses startsWith('touch') instead of
indexOf('touch') === 0, which is the same for strings.
Removes the no-plusplus, no-nested-ternary, no-multi-assign, no-param-reassign, no-else-return, no-shadow and no-unused-expressions disables from range_selector with equivalent rewrites: - i++ / x++ statements become += 1 (the values are numbers); - chained assignments to plain fields and locals become two statements, inner target first; - nested ternaries become if/else that evaluate the same branch; - reassigned parameters become new locals; - `a && b()` statements become if statements.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.