Skip to content

Fluent Next: sync the custom accent formula with Blazor - #36413

Open
Raushen wants to merge 6 commits into
DevExpress:mainfrom
Raushen:27_1_fluent-next_accent-sync
Open

Raushen wants to merge 6 commits into
DevExpress:mainfrom
Raushen:27_1_fluent-next_accent-sync

Conversation

@Raushen

@Raushen Raushen commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Raushen
Raushen requested a review from a team as a code owner November 18, 2026 19:43
Copilot AI balanced review requested due to automatic review settings November 18, 2026 19:43
@Raushen Raushen self-assigned this Nov 18, 2026
@Raushen Raushen added the 27_1 label Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The palette formula change leaves outdated screenshot baselines causing test failures, while numeric tests lack coverage for the new lightness clamp and low-chroma adjustment.

2 open issues
What changed in this PR

Updates Fluent Next’s custom accent palette formula to match Blazor, with a normalized base color shared by all derived shades.

Changes:

  • Clamp base lightness, adjust low-chroma accents, and preserve opaque output.
  • Replace the previous accent source and settings with a single base property.
  • Update contract checks, baselines, and browser tests for the revised formula.
File Description
packages/​devextreme-scss/​tools/​naming/​accent-contract.json Documents the normalized base and shared formula.
packages/​devextreme-scss/​tests/​runtime-reads.test.ts Uses the revised accent contract names.
packages/​devextreme-scss/​tests/​public-surface.baseline.json Replaces retired accent properties with the base property.
packages/​devextreme-scss/​tests/​fluent-next-naming.test.ts Updates accent naming exclusions.
packages/​devextreme-scss/​tests/​calc-budget.json Adjusts expected calculation counts.
packages/​devextreme-scss/​tests/​accent-palette.test.ts Checks base declarations and inherited opacity.
packages/​devextreme-scss/​scss/​widgets/​fluent-next/​_accent-color.scss Implements normalization and the revised 18-step palette.
e2e/​testcafe-devextreme/​tests/​common/​accentColor.ts Updates palette assertions and the named-color test input.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 20:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The accent-palette normalization change has no active review issues.

2 open issues

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 23:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the accent palette normalization changes.

2 open issues

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 23:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the accent palette changes.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants