Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The palette formula change leaves outdated screenshot baselines causing test failures, while numeric tests lack coverage for the new lightness clamp and low-chroma adjustment.
2 open issues
What changed in this PR
Updates Fluent Next’s custom accent palette formula to match Blazor, with a normalized base color shared by all derived shades.
Changes:
- Clamp base lightness, adjust low-chroma accents, and preserve opaque output.
- Replace the previous accent source and settings with a single base property.
- Update contract checks, baselines, and browser tests for the revised formula.
| File | Description |
|---|---|
packages/devextreme-scss/tools/naming/accent-contract.json |
Documents the normalized base and shared formula. |
packages/devextreme-scss/tests/runtime-reads.test.ts |
Uses the revised accent contract names. |
packages/devextreme-scss/tests/public-surface.baseline.json |
Replaces retired accent properties with the base property. |
packages/devextreme-scss/tests/fluent-next-naming.test.ts |
Updates accent naming exclusions. |
packages/devextreme-scss/tests/calc-budget.json |
Adjusts expected calculation counts. |
packages/devextreme-scss/tests/accent-palette.test.ts |
Checks base declarations and inherited opacity. |
packages/devextreme-scss/scss/widgets/fluent-next/_accent-color.scss |
Implements normalization and the revised 18-step palette. |
e2e/testcafe-devextreme/tests/common/accentColor.ts |
Updates palette assertions and the named-color test input. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.