Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The focus assertion fails in Shadow DOM mode because it checks the fixture’s shadow root for a body-mounted overlay instead of using document.activeElement.
1 open issue
What changed in this PR
This PR prevents page scrolling when Overlay and DropDownBox move focus after opening.
Changes:
- Uses native
focus({ preventScroll: true })for overlay content and the first tabbable DropDownBox element. - Adds regression tests checking that off-screen content receives focus without changing the page’s scroll position.
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets/overlay.tests.js |
Tests overlay focus without page scrolling. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownBox.tests.js |
Tests popup content focus without page scrolling. |
packages/devextreme/js/__internal/ui/overlay/overlay.ts |
Prevents scrolling when focusing overlay content. |
packages/devextreme/js/__internal/ui/drop_down_box.ts |
Prevents scrolling when focusing the first tabbable element. |
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
The focus helper can leave inputs horizontally offscreen or partially clipped because it only adjusts vertical scrolling and uses outer bounds rather than the container’s visible client viewport.
2 open issues
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
Human assessment is needed because the scrolling calculations mix transformed and unscaled coordinates, potentially leaving focused inputs clipped in scaled containers.
No open issues 🎉
2 resolved since last review
Review effort: Balanced
| shiftTop += top; | ||
| shiftLeft += left; |

No description provided.