Repository navigation
refactor(app): share Beats track duration formatter - #2126
Merged
Merged
Conversation
Contributor
Plugin Module Size GatePolicy: modules over 3 MB must be delivered as plugins; plugin modules over 5 MB must document cache management.
|
Contributor
🚀 PR Quick Check Summary
|
ucguy4u
added
the
docs-not-needed
Cursor
cursor
Bot
force-pushed
the
cursor/dedupe-music-duration-c596
branch
from
October 23, 2026 21:34
06dff6d to
b33f00f
Compare
Contributor
🚀 PR Quick Check Summary
|
Contributor
🚀 PR Quick Check Summary
|
Contributor
🚀 PR Quick Check Summary
|
Extract formatMusicTrackDuration and use it from music_screen instead of three identical private helpers. docs-not-needed: internal dedupe only; no user-facing behavior change. Co-authored-by: Uday Chauhan <chauhan.s.uday26@gmail.com>
Co-authored-by: Uday Chauhan <chauhan.s.uday26@gmail.com>
Co-authored-by: Uday Chauhan <chauhan.s.uday26@gmail.com>
cursor
Bot
force-pushed
the
cursor/dedupe-music-duration-c596
branch
from
October 23, 2026 22:00
ecdae80 to
5b89735
Compare
Contributor
🚀 PR Quick Check Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatMusicTrackDurationfor Beats player labels (m:ss)._formatDurationhelpers inmusic_screen.dartwith the shared function.Test plan
cd app && flutter test test/features/music/presentation/music_duration_format_test.dart