Repository navigation
fix(dgw): stop libsql from closing connections twice - #2074
Conversation
libsql 0.9.30 closes a local connection's SQLite handle twice when it's dropped, which sometimes crashes Gateway on startup with 0xc0000005. Patch it with the tursodatabase/libsql#2261 fix from the Devolutions fork, tag 0.9.30-devo.1 (0.9.30 plus that one commit). Issue: #2070 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
🟢 Approval recommended
The fork contains only the verified upstream fix, and the lockfile consistently pins all affected crates.
0 open findings
What changed in this PR
Temporarily patches Gateway’s libsql dependency to prevent double-closing local connections during startup and upgrades.
Changes:
- Uses Devolutions’ patched libsql 0.9.30 tag.
- Updates all libsql lockfile entries to the pinned fork commit.
| File | Description |
|---|---|
Cargo.toml |
Adds the temporary libsql patch. |
Cargo.lock |
Locks libsql crates to the patched commit. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
libsql 0.10.0 ships the tursodatabase/libsql#2261 fix, the same commit the Devolutions fork tag carried, so drop the [patch.crates-io] entry and bump the libsql requirement to 0.10 in every crate. Issue: #2070 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
libsql 0.9.30 closes a local connection twice when it's dropped (tursodatabase/libsql#2251). Since #2039 Gateway drops connections on startup, so some upgrades crash with
0xc0000005. libsql 0.10.0 ships the upstream fix (tursodatabase/libsql#2261), so this moves Gateway to it.0.10.0 also updates the bundled SQLite from 3.45.1 to 3.47.0. The database file format doesn't change, so existing databases are unaffected.
Tested on Windows:
SELECT 1/ drop on a shared file DB: libsql 0.9.30 crashed 25/50 runs, 0.10.0 0/50cargo clippy --workspace --tests -- -D warningsandcargo test --workspacepassFixes #2070
🤖 Generated with Claude Code