refactor: make tiled client smaller - #1665
ZohebShaikh wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 46 46
Lines 3665 3665
=======================================
Hits 3531 3531
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| "tiled[client]>=0.2.4", | ||
| "tiled[minimal-client]>=0.2.4", | ||
| "pyarrow", # Needed for TiledWriter | ||
| "pandas", # Needed for TiledWriter | ||
| "ndindex", # Needed for TiledWriter | ||
| "bluesky[plotting]>=1.14.0", # plotting includes matplotlib, required for BestEffortCallback in run plans |
There was a problem hiding this comment.
I'm going backwards and forward on whether I should put this in tiled or bluesky-tiled-plugin or just leave it on blueapi level
There was a problem hiding this comment.
If these dependencies are only needed by the TiledWriter, they should be added to wherever TiledWriter is defined.
tpoliaw
left a comment
tpoliaw
left a comment
There was a problem hiding this comment.
Reducing the tiled dependencies is great but not if we have to start managing transitive dependencies.
| "tiled[client]>=0.2.4", | ||
| "tiled[minimal-client]>=0.2.4", | ||
| "pyarrow", # Needed for TiledWriter | ||
| "pandas", # Needed for TiledWriter | ||
| "ndindex", # Needed for TiledWriter | ||
| "bluesky[plotting]>=1.14.0", # plotting includes matplotlib, required for BestEffortCallback in run plans |
There was a problem hiding this comment.
If these dependencies are only needed by the TiledWriter, they should be added to wherever TiledWriter is defined.
2 participants
Dependencies reduced by 731M to 522M.
The main thing removed is llvmlite 171.2 MB