Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
DiamondLightSource
/
python-murfey
Public
Notifications
You must be signed in to change notification settings
Fork
1
Star
2
Code
Issues
34
Pull requests
4
Actions
Projects
Wiki
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Wiki
Security and quality
Insights
Fix slot number determination logic for the FIB workflow
- #842
#842
Merged
tieneupin
merged 15 commits into
main
DiamondLightSource/python-murfey:main
from
slot-number-fix
DiamondLightSource/python-murfey:slot-number-fix
Copy head branch name to clipboard
Jul 24, 2026
Conversation
Commits
15
(15)
Checks
Files changed
Merged
Fix slot number determination logic for the FIB workflow
#842
tieneupin
merged 15 commits into
main
DiamondLightSource/python-murfey:main
from
slot-number-fix
DiamondLightSource/python-murfey:slot-number-fix
Copy head branch name to clipboard
Commits
Commits on Jul 16, 2026
Updated slot number determination logic in the 'StagePositionValues' Pydantic model
tieneupin
committed
a1606c7
View commit details
Copy full SHA for a1606c7
Browse repository at this point
Updated tests to reflect new stage position logic
tieneupin
committed
f52b8e6
View commit details
Copy full SHA for f52b8e6
Browse repository at this point
Commits on Jul 24, 2026
Moved slot number determination logic into a separate utility function that accepts a variable 'rotation_offset' parameter
tieneupin
committed
d406737
View commit details
Copy full SHA for d406737
Browse repository at this point
Updated FIB context and 'register_milling_progress' workflow so that the rotation offset parameter is extracted from the MachineConfig as a dict from the 'calibrations' field
tieneupin
committed
31e4681
View commit details
Copy full SHA for 31e4681
Browse repository at this point
Updated FIBContext tests
tieneupin
committed
e0bd468
View commit details
Copy full SHA for e0bd468
Browse repository at this point
Pass values directly into 'get_slot_number' function instead of Pydantic model
tieneupin
committed
f06a942
View commit details
Copy full SHA for f06a942
Browse repository at this point
Forgot to remove commented out block
tieneupin
committed
5635666
View commit details
Copy full SHA for 5635666
Browse repository at this point
Pass stage position values to 'get_slot_number' directly in the FIBContext
tieneupin
committed
9310e0f
View commit details
Copy full SHA for 9310e0f
Browse repository at this point
Updated 'register_atlas' workflow so that rotation offset information is fed in from the MachineConfig
tieneupin
committed
7ef8504
View commit details
Copy full SHA for 7ef8504
Browse repository at this point
Updated tests
tieneupin
committed
1e0fc41
View commit details
Copy full SHA for 1e0fc41
Browse repository at this point
Missed fixing an instance of 'get_slot_number'
tieneupin
committed
aeaffd6
View commit details
Copy full SHA for aeaffd6
Browse repository at this point
Merged recent changes from 'main' branch
tieneupin
committed
73ef54e
View commit details
Copy full SHA for 73ef54e
Browse repository at this point
Fixed broken test
tieneupin
committed
8791a54
View commit details
Copy full SHA for 8791a54
Browse repository at this point
Added comments about function purpose and angle units
tieneupin
committed
ab0f5a1
View commit details
Copy full SHA for ab0f5a1
Browse repository at this point
Added comments about angle units
tieneupin
committed
6829465
View commit details
Copy full SHA for 6829465
Browse repository at this point
You can’t perform that action at this time.