Fix for multiple smartem grid registration - #887
Merged
Merged
Conversation
… the dm has been read
…whether one exists for the data collection group already
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 55.10% 53.59% -1.52%
==========================================
Files 102 103 +1
Lines 11367 12137 +770
Branches 1508 1683 +175
==========================================
+ Hits 6264 6505 +241
- Misses 4767 5264 +497
- Partials 336 368 +32 🚀 New features to boost your workflow:
|
stephen-riggs
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently multiple smartem grids are registered for each EPU atlas. Some of these are as a result of duplication in the code, some are because the
Atlas.dmis edited triggering another endpoint hit. This should resolve all of these