CI check: 484_format_missing_comma (do not merge) - #2
Closed
DisciplinedSoftware wants to merge 1 commit into
Closed
Conversation
Many compilers (gfortran, ifort, ifx) accept a missing comma between
a character-string edit descriptor and a neighbouring format item,
e.g. FORMAT('a' 1x,'b'), FORMAT(15x'a') or FORMAT('a' 'b').
Following the extension convention, 'format-missing-comma' is added
to the EXTENSIONS list in utils.py and the relaxation is implemented
in Format_Item_C1002, whose match logic is split into the standard
C1002 pass and an extension fallback. Found while parsing MODFLOW-2005
(gwf2swr7.f, gwf2swi27.fpp, gwf2lak7.f, gwf2sfr7.f); also covers the
example in issue stfc#484.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
CI green (fparser unit tests: success). Closing — this was only a CI vehicle for upstream stfc#526. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to run CI on the fork while upstream stfc#526 awaits first-contributor workflow approval.