Skip to content

refactor: fix React Compiler violations in Tabs#1077

Merged
henningmu merged 1 commit into
mainfrom
henningmu/fix-reactist-1070
Jun 19, 2026
Merged

refactor: fix React Compiler violations in Tabs#1077
henningmu merged 1 commit into
mainfrom
henningmu/fix-reactist-1070

Conversation

@henningmu

@henningmu henningmu commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Closes #1070

Short description

Migrates the Tabs selected-id subscriptions from AriaKit store member hooks to useStoreState, including nullable context-store reads.

This keeps the hook calls unconditional for React Compiler and lets the tabs file be removed from .react-compiler.rec.json.

PR Checklist

  • Added tests for bugs / new features (covered by existing Tabs tests)
  • Updated docs (not applicable)
  • Reviewed and approved Chromatic visual regression tests in CI

@doistbot doistbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates refactor: fix React Compiler violations in Tabs. No issues were flagged in the reviewed diff.

Share FeedbackReview Logs

@henningmu henningmu self-assigned this Jun 19, 2026
@henningmu henningmu requested review from a team and nats12 and removed request for a team June 19, 2026 18:25
@henningmu henningmu merged commit 43eb390 into main Jun 19, 2026
11 checks passed
@henningmu henningmu deleted the henningmu/fix-reactist-1070 branch June 19, 2026 18:25
@doist-release-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 33.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doist-release-bot doist-release-bot Bot added the Released PRs that have been merged and released label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Released PRs that have been merged and released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: Fix React Compiler violations in Tabs

2 participants