Repository navigation
fix(adk): plain bridge marker and picklable Governed* classes (#1447) - #1518
Merged
Merged
Conversation
The last_call bridge marker is a ClassVar, so pydantic no longer turns it into a private attribute (a truthy ModelPrivateAttr). GovernedLiteLlm, GovernedGemini and GovernedLiteLLMClient resolve by name on donkey_kit.integrations.adk through a PEP 562 __getattr__, so pickle finds them; a class last_call_bridged() builds from a user's own class still has no name there. Part of #1447 Co-authored-by: Cursor <cursoragent@cursor.com>
tommasobolis
marked this pull request as draft
October 30, 2026 11:48
tommasobolis
marked this pull request as ready for review
October 30, 2026 11:55
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1447 (ADK slice; #1510 carries Closes and merges last).
Made with Cursor