Repository navigation
Fix cs/log-forging alerts by stripping line endings before logging - #409
Merged
Merged
Conversation
Addresses cs/log-forging code scanning alerts by applying
ReplaceLineEndings(string.Empty) to request-derived values (CIBA id,
consent returnUrl, logoutId) in the IdentityServer UI template pages and
Pages/Log.cs LoggerMessage wrappers across IdentityServer/v7, v8, BFF and
various. Also replaces the positional {0} placeholder with a named one.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The consistent logging-only changes preserve request processing and existing null handling, with no blocking defects identified.
No open issues 🎉
What changed in this PR
This PR hardens logging in the shared IdentityServer UI samples against log forging by removing line endings from request-derived log values without changing the inputs used for authentication or consent processing.
Changes:
- Sanitizes identifiers and return URLs in direct logging calls across IdentityServer, BFF, and Owin samples.
- Applies the same sanitization in
LoggerMessagewrappers. - Replaces positional consent-log placeholders with named
{returnUrl}placeholders.
| File | Description |
|---|---|
| various/clients/Owin/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| various/clients/Owin/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| various/clients/Owin/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/UserManagement/FullSample/UserManagementSample/Pages/Consent.cshtml.cs | Sanitizes logged return URL. |
| IdentityServer/v8/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/UserInteraction/WindowsAuthentication/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/UserInteraction/WindowsAuthentication/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/UserInteraction/WindowsAuthentication/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/UserInteraction/StepUp/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/UserInteraction/StepUp/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/UserInteraction/StepUp/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/UserInteraction/ProfileService/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/UserInteraction/ProfileService/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/UserInteraction/ProfileService/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/UserInteraction/DynamicProviders/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/UserInteraction/DynamicProviders/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/UserInteraction/DynamicProviders/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/UserInteraction/Ciba/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/UserInteraction/Ciba/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/UserInteraction/Ciba/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/SessionMigration/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/SessionMigration/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/SessionMigration/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/SessionManagement/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/SessionManagement/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/SessionManagement/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/SAML/IdPInitiated/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/SAML/IdPInitiated/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/SAML/IdPInitiated/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/SAML/Basic/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/SAML/Basic/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/SAML/Basic/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/Quickstarts/6_JS_without_backend/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/Quickstarts/6_JS_with_backend/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/Quickstarts/5_AspNetIdentity/src/IdentityServerAspNetIdentity/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/Quickstarts/4_EntityFramework/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/Quickstarts/3a_TokenManagement/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/Quickstarts/3_AspNetCoreAndApis/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/Quickstarts/2_InteractiveAspNetCore/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/PAT/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/PAT/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/PAT/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/MTLS/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/MTLS/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/MTLS/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/McpDemo/McpDemo.IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/IdentityServerHost/src/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/IdentityServerHost/src/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/IdentityServerHost/src/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/Diagnostics/Otel/src/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v8/Diagnostics/Otel/src/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v8/Diagnostics/Otel/src/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v8/Diagnostics/Aspire/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/Configuration/IdentityServerHost/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v8/AspNetIdentityPasskeys/IdentityServerAspNetIdentityPasskeys/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/UserInteraction/WindowsAuthentication/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/UserInteraction/WindowsAuthentication/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/UserInteraction/WindowsAuthentication/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/UserInteraction/StepUp/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/UserInteraction/StepUp/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/UserInteraction/StepUp/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/UserInteraction/ProfileService/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/UserInteraction/ProfileService/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/UserInteraction/ProfileService/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/UserInteraction/DynamicProviders/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/UserInteraction/DynamicProviders/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/UserInteraction/DynamicProviders/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/UserInteraction/Ciba/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/UserInteraction/Ciba/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/UserInteraction/Ciba/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/SessionMigration/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/SessionMigration/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/SessionMigration/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/SessionManagement/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/SessionManagement/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/SessionManagement/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/Quickstarts/6_JS_without_backend/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/Quickstarts/6_JS_with_backend/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/Quickstarts/5_AspNetIdentity/src/IdentityServerAspNetIdentity/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/Quickstarts/4_EntityFramework/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/Quickstarts/3a_TokenManagement/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/Quickstarts/3_AspNetCoreAndApis/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/Quickstarts/2_InteractiveAspNetCore/src/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/PAT/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/PAT/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/PAT/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/MTLS/IdentityServerHost/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/MTLS/IdentityServerHost/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/MTLS/IdentityServerHost/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/McpDemo/McpDemo.IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/IdentityServerHost/src/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/IdentityServerHost/src/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/IdentityServerHost/src/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/Diagnostics/Otel/src/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| IdentityServer/v7/Diagnostics/Otel/src/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| IdentityServer/v7/Diagnostics/Otel/src/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| IdentityServer/v7/Diagnostics/Aspire/IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/Configuration/IdentityServerHost/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| IdentityServer/v7/AspNetIdentityPasskeys/IdentityServerAspNetIdentityPasskeys/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| BFF/v4/TokenExchange/TokenExchange.IdentityServer/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| BFF/v4/TokenExchange/TokenExchange.IdentityServer/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| BFF/v4/TokenExchange/TokenExchange.IdentityServer/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| BFF/v4/MultiFrontendSSO/MultiFrontendSSO.IdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| BFF/v4/docker/ContainerizedIdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| BFF/v4/docker/ContainerizedIdentityServer/Pages/Account/Logout/LoggedOut.cshtml.cs | Sanitizes logged logout ID. |
| BFF/v3/TokenExchange/TokenExchange.IdentityServer/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| BFF/v3/TokenExchange/TokenExchange.IdentityServer/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| BFF/v3/TokenExchange/TokenExchange.IdentityServer/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
| BFF/v3/docker/ContainerizedIdentityServer/Pages/Log.cs | Sanitizes IDs and return URLs in wrappers. |
| BFF/v3/docker/ContainerizedIdentityServer/Pages/Account/Logout/LoggedOut.cshtml.cs | Sanitizes logged logout ID. |
| BFF/v2/TokenExchange/TokenExchange.IdentityServer/Pages/Consent/Index.cshtml.cs | Sanitizes logged return URL; names placeholder. |
| BFF/v2/TokenExchange/TokenExchange.IdentityServer/Pages/Ciba/Index.cshtml.cs | Sanitizes logged login ID. |
| BFF/v2/TokenExchange/TokenExchange.IdentityServer/Pages/Ciba/Consent.cshtml.cs | Sanitizes logged consent IDs. |
Review effort: Balanced
NoMatchingBackchannelLoginRequest and NoConsentMatchingRequest now accept string? and use ?.ReplaceLineEndings so a missing request value no longer throws NullReferenceException. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
maartenba
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the open
cs/log-forgingcode scanning alerts.Changes
id,Input.Id, consentreturnUrl,logoutId) are now passed throughReplaceLineEndings(string.Empty)before logging. This method is a recognized CodeQL sanitizer forcs/log-forging.IdentityServer/v7,IdentityServer/v8,BFF/andvarious/, including:_logger.LogX(...)calls inPages/**/*.cshtml.csPages/Log.csLoggerMessagewrappers used by newer templates (not flagged today, but they have the same issue){0}placeholder in"No consent request matching request: {0}"is now a named placeholder ({returnUrl}).Structured logging placeholders are unchanged. This PR adds no shared helpers.
Validation
dotnet buildsucceeds for all 56 touched projects.