Repository navigation
Remove checking for installations we know don't exist - #31
Merged
Merged
Conversation
ocaisa
commented
Oct 15, 2026
| if eessi_version in CPU_ARCHITECTURE_OVERRIDES: | ||
| base_json_metadata["architectures_map"][eessi_version] = CPU_ARCHITECTURE_OVERRIDES[eessi_version] | ||
| # CPU_ARCHITECTURE_OVERRIDES is a nested dict so we need a deepcopy | ||
| base_json_metadata["architectures_map"][eessi_version] = copy.deepcopy(CPU_ARCHITECTURE_OVERRIDES[eessi_version]) |
Member
Author
There was a problem hiding this comment.
The lack of a deepcopy() was the cause of the problem patched in #30
ocaisa
commented
Oct 15, 2026
Comment on lines
+192
to
+193
| if len(base_version_dict["cpu_arch"]) == 0: | ||
| raise RuntimeError(f"List of CPU archs for {modulefile} is 0, that can't be right!") |
Member
Author
There was a problem hiding this comment.
This will at least error if you get zero CPU archs, that should not happen
Member
Author
|
Verified the json from the CI manually against #30, the only difference was the timestamp. This is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.