Skip to content

add defaults for compat layer variant symlinks#270

Merged
boegel merged 3 commits into
EESSI:mainfrom
bedroge:compat_synmlinks_defaults
Jun 9, 2026
Merged

add defaults for compat layer variant symlinks#270
boegel merged 3 commits into
EESSI:mainfrom
bedroge:compat_synmlinks_defaults

Conversation

@bedroge

@bedroge bedroge commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Accompanying PR for EESSI/compatibility-layer#235, this creates the defaults symlinks for compat layer variant symlinks.

As an example, we get this structure:

/cvmfs/software.eessi.io/versions/2026.06/compat/linux/x86_64/etc/hosts
-> 
'$(EESSI_202606_COMPAT_ETC_HOSTS):-/cvmfs/software.eessi.io/defaults/compat/etc/hosts'
->
'$(EESSI_COMPAT_ETC_HOSTS):-/etc/hosts'

I.e., by default every symlink will point to the same file on the host, but you can override the default (i.e. for all EESSI versions) or per version.

Comment on lines 37 to +38
defaults/override: '$(EESSI_LIB_OVERRIDE_DEFAULT:-/dev/null)'
defaults/compat/etc/ethers: '$(EESSI_COMPAT_ETC_ETHERS:-/etc/ethers)'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these compat variables also have _DEFAULT, i.e. EESSI_COMPAT_ETC_ETHERS_DEFAULT? I figured the name would be clear enough without it, it's already in a defaults directory anyway, but for consistency we could add it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No DEFAULT makes sense to me, as was discussed in our meeting (I think @ocaisa had a good reasoning for it)

@boegel

boegel commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@bedroge Do we need to worry here that we only want these for EESSI 2026+ ?

@bedroge

bedroge commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

@bedroge Do we need to worry here that we only want these for EESSI 2026+ ?

No, they're in a top-level defaults directory, and they're only used by the variant symlinks in 2026.06 (and later). They won't affect older versions in any way.

@boegel boegel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 4bf99dd into EESSI:main Jun 9, 2026
22 checks passed
@bedroge bedroge deleted the compat_synmlinks_defaults branch June 9, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants