Repository navigation
Conversation
…it is complete in the sense that it supports all architectures, and all builds are done from the same software-layer commit
casparvl
pushed a commit
to casparvl/software-layer
that referenced
this pull request
Aug 10, 2026
…mplement this in a seperate PR EESSI#1564
Member
|
In https://github.com/EESSI/software-layer/blob/main/.github/workflows/test-software.eessi.io.yml there's a maintained list of all the architectures and accelerators for each EESSI version. I think it makes sense to have a source of truth for that list (a yaml file?) and to also use it for this CI. |
…file The list of supported CPU and accelerator targets per EESSI version was embedded as env variables in test-software.eessi.io.yml. Move it to .github/workflows/eessi_targets.json so it can be reused by other workflows and scripts (e.g. a check on the bot's build status), without duplicating it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replace the placeholder SUPPORTED_TARGETS mapping with targets read from the shared .github/workflows/eessi_targets.json (also used by test-software.eessi.io.yml), so the list is defined only once. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
#1745 Single source of truth - still need to test the PR though. |
Collaborator
Author
yq infers its output format from the input file extension, so reading a .json file produced quoted JSON strings (e.g. "x86_64/amd/zen2"), which broke the CPU target detection. jq -r prints raw strings. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…facts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Status update: this still needs some final changes from #1745 to be merged into this branch. Then, we can leverage the single source of truth json file to check all the built targets. TODO: I don't think this can check accelerator-builds yet, and related is that we should make the code aware of 'for:' values that contain multiple architectures. |
TOML is parseable from Python's standard library (tomllib, 3.11+) and from the shell with yq, and unlike JSON it allows comments. yq is called with explicit input/output formats (-p toml -o yaml) so the output is raw strings, rather than relying on yq inferring the output format from the file extension. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a CI that can check the 'bot:status last_build' output to see if it is complete in the sense that it supports all architectures, and all builds are done from the same software-layer commit.
TODO: