Web font substitution for SVG export - #2547
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web font substitution for SVG export
SVG text was measured server-side with one font but rendered by the browser with another. Office cloud fonts such as Aptos Narrow are never visible to browsers, which fell back to wider fonts, so text overflowed and axis labels were miscalculated, especially on Linux.
Changes
FontRenderTarget(Document/Web) andOpenTypeFontEngine.GetFamilyForTarget. ConfigurableWebFontSubstitutionswith defaults for Office cloud fonts.RenderContext.ForTargetandGetMeasurementShaper.SvgRenderOptions.FontTargetdefaults toWeb, and PDF is unaffected.ITextMeasurer, onlyITextShaper. Axes are measured with the axis font instead of the theme heading font.(TextShaper)casts that crashed when metrics-only shapers were used.Tests
Substitution policy,
RenderContext, SVG output, and measurement consistency. All independent of installed fonts.