Add ECX GUI wiring - #6163
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f6db1e8. Configure here.
| displayBuyCrypto: false, | ||
| isImportKeySupported: true, | ||
| isStakingSupported: false | ||
| }, |
There was a problem hiding this comment.
Shared ECX and XEC wallet name
Low Severity
ecashcom reuses lstrings.string_first_ecash_wallet_name (My eCash), the same default as XEC ecash. getUniqueWalletName only uniquifies within a pluginId, so both wallets can appear with identical names, which undercuts keeping ECX distinct from XEC.
Reviewed by Cursor Bugbot for commit f6db1e8. Configure here.
f6db1e8 to
5953123
Compare
- register ecashcom behind its own init flag - pin edge-currency-plugins to the ECX PR branch - cover ECX/XEC metadata separation
5953123 to
1e79b1e
Compare


Summary
bitcoinecashcurrency plugin behind a separateBITCOINECASH_INITgate so ECX stays distinct from existing XECecash.edge-currency-pluginsto the ECX PR branch at4047454915becfe680098f550ca12ab6545f12d8until the plugin PR is merged and released.Correlated plugin PR: EdgeApp/edge-currency-plugins#456
Testing
npx eslint src/util/corePlugins.ts src/envConfig.ts src/constants/WalletAndCurrencyConstants.ts src/__tests__/constants/WalletAndCurrencyConstants.test.ts src/components/modals/WalletListMenuModal.tsxgit diff --checknpx tsc --noEmitnpm test -- src/__tests__/constants/WalletAndCurrencyConstants.test.ts --runInBandnpm test -- --runInBand --findRelatedTests src/components/modals/WalletListMenuModal.tsx --passWithNoTeststsc+ fullnpm test(98 suites / 705 tests passed)Notes
BITCOINECASH_INITcleans tofalse; this avoids enabling the pre-launch/drynet wallet unintentionally.My eCashwallet-name string; no ECX-specific localization key exists yet.