Skip to content

Add ECX GUI wiring - #6163

Open
samholmes wants to merge 1 commit into
EdgeApp:developfrom
bobbythelobster:claudine/ecash-ecx-gui
Open

Add ECX GUI wiring#6163
samholmes wants to merge 1 commit into
EdgeApp:developfrom
bobbythelobster:claudine/ecash-ecx-gui

Conversation

@samholmes

@samholmes samholmes commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Register the new bitcoinecash currency plugin behind a separate BITCOINECASH_INIT gate so ECX stays distinct from existing XEC ecash.
  • Add ECX GUI metadata for SegWit/import/max-spend behavior.
  • Add ECX to wallet menu sign-message and xpub-view capability lists.
  • Temporarily pin edge-currency-plugins to the ECX PR branch at 4047454915becfe680098f550ca12ab6545f12d8 until the plugin PR is merged and released.

Correlated plugin PR: EdgeApp/edge-currency-plugins#456

Testing

  • npx eslint src/util/corePlugins.ts src/envConfig.ts src/constants/WalletAndCurrencyConstants.ts src/__tests__/constants/WalletAndCurrencyConstants.test.ts src/components/modals/WalletListMenuModal.tsx
  • git diff --check
  • npx tsc --noEmit
  • npm test -- src/__tests__/constants/WalletAndCurrencyConstants.test.ts --runInBand
  • npm test -- --runInBand --findRelatedTests src/components/modals/WalletListMenuModal.tsx --passWithNoTests
  • precommit hook: tsc + full npm test (98 suites / 705 tests passed)

Notes

  • ECX remains disabled by default because missing BITCOINECASH_INIT cleans to false; this avoids enabling the pre-launch/drynet wallet unintentionally.
  • ECX currently reuses the existing user-facing My eCash wallet-name string; no ECX-specific localization key exists yet.

@socket-security

socket-security Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedreact-native-custom-tabs@​0.1.8 ⏵ 0.1.8N/AN/AN/AN/AN/A
Updatedreact-native-store-review@​0.4.3N/AN/AN/AN/AN/A

View full report

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f6db1e8. Configure here.

Comment thread src/constants/WalletAndCurrencyConstants.ts
displayBuyCrypto: false,
isImportKeySupported: true,
isStakingSupported: false
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared ECX and XEC wallet name

Low Severity

ecashcom reuses lstrings.string_first_ecash_wallet_name (My eCash), the same default as XEC ecash. getUniqueWalletName only uniquifies within a pluginId, so both wallets can appear with identical names, which undercuts keeping ECX distinct from XEC.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f6db1e8. Configure here.

- register ecashcom behind its own init flag
- pin edge-currency-plugins to the ECX PR branch
- cover ECX/XEC metadata separation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants