Add SimpleSwap swap support - #6167
Open
j0ntz wants to merge 1 commit into
Open
Conversation
2 tasks
Contributor
Author
Registers the SimpleSwap swap plugin: the SIMPLESWAP_INIT env config, the core plugin entry, the provider icon and merchant contact, and the terms, privacy and AML/KYC links the swap terms modal shows before the first quote.
j0ntz
marked this pull request as ready for review
August 19, 2026 23:25
j0ntz
force-pushed
the
jon/simpleswap-swap-support
branch
from
August 19, 2026 23:25
1af42e4 to
bd3a86d
Compare
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-exchange-plugins#488: the SimpleSwap plugin itself. This PR only registers it, so it is inert until that lands and publishes.
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana: https://app.asana.com/0/1215088146871429/1217205278669378
Registers SimpleSwap, the swap provider added in
EdgeApp/edge-exchange-plugins#488,
so the plugin loads in the app. This is SimpleSwap's own wiring from
#6136, recreated on an
EdgeApp branch so it can land from here, with their authorship on the commit.
src/envConfig.tscarriesSIMPLESWAP_INITwith anapiKey, matching the othercentralized providers. An empty key makes the plugin factory throw, so builds
without the key skip SimpleSwap entirely.
src/util/corePlugins.tscarries theswapPluginsentry.src/components/modals/SwapVerifyTermsModal.tsxcarries the terms, privacyand AML/KYC links shown before the first SimpleSwap quote.
src/actions/CategoriesActions.tsandsrc/constants/MerchantContacts.tscarrythe provider icon and merchant contact.
The icon at
content.edge.app/simpleswap.pngis not on the content server yet,so the provider row renders a broken image until it is uploaded. SimpleSwap
attached the 64x64 and 600x210 assets, at 1x and 2x, to
#6136.
Testing
Driven on the iOS simulator against the real SimpleSwap API, with every other
swap provider disabled locally so the engine had to route through SimpleSwap: an
80 XLM to XMR swap from
My Stellarexecuted to the success scene, and theStellar send carried SimpleSwap's numeric deposit memo. The plugin's below-limit
error also renders correctly ("Amount is below the min limit of 66.9549714 XLM").
Screenshots below.
Note
Cursor Bugbot is generating a summary for commit bd3a86d. Configure here.