Skip to content

Add SimpleSwap swap support - #6167

Open
j0ntz wants to merge 1 commit into
developfrom
jon/simpleswap-swap-support
Open

Add SimpleSwap swap support#6167
j0ntz wants to merge 1 commit into
developfrom
jon/simpleswap-swap-support

Conversation

@j0ntz

@j0ntz j0ntz commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/edge-exchange-plugins#488: the SimpleSwap plugin itself. This PR only registers it, so it is inert until that lands and publishes.

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

Asana: https://app.asana.com/0/1215088146871429/1217205278669378

Registers SimpleSwap, the swap provider added in
EdgeApp/edge-exchange-plugins#488,
so the plugin loads in the app. This is SimpleSwap's own wiring from
#6136, recreated on an
EdgeApp branch so it can land from here, with their authorship on the commit.

  • src/envConfig.ts carries SIMPLESWAP_INIT with an apiKey, matching the other
    centralized providers. An empty key makes the plugin factory throw, so builds
    without the key skip SimpleSwap entirely.
  • src/util/corePlugins.ts carries the swapPlugins entry.
  • src/components/modals/SwapVerifyTermsModal.tsx carries the terms, privacy
    and AML/KYC links shown before the first SimpleSwap quote.
  • src/actions/CategoriesActions.ts and src/constants/MerchantContacts.ts carry
    the provider icon and merchant contact.

The icon at content.edge.app/simpleswap.png is not on the content server yet,
so the provider row renders a broken image until it is uploaded. SimpleSwap
attached the 64x64 and 600x210 assets, at 1x and 2x, to
#6136.

Testing

Driven on the iOS simulator against the real SimpleSwap API, with every other
swap provider disabled locally so the engine had to route through SimpleSwap: an
80 XLM to XMR swap from My Stellar executed to the success scene, and the
Stellar send carried SimpleSwap's numeric deposit memo. The plugin's below-limit
error also renders correctly ("Amount is below the min limit of 66.9549714 XLM").
Screenshots below.


Note

Cursor Bugbot is generating a summary for commit bd3a86d. Configure here.

@j0ntz

j0ntz commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

simpleswap terms modal

simpleswap terms modal

simpleswap quote

simpleswap quote

swap success

swap success

xlm tx with memo

xlm tx with memo

stellar broadcast

stellar broadcast

Captured by the agent's in-app test run (build-and-test).

Registers the SimpleSwap swap plugin: the SIMPLESWAP_INIT env config, the
core plugin entry, the provider icon and merchant contact, and the terms,
privacy and AML/KYC links the swap terms modal shows before the first
quote.
@j0ntz
j0ntz marked this pull request as ready for review August 19, 2026 23:25
@j0ntz
j0ntz force-pushed the jon/simpleswap-swap-support branch from 1af42e4 to bd3a86d Compare August 19, 2026 23:25

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

Tip: disable this comment in your organization's Code Review settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants