fix(opentelemetry): avoid duplicate service.name/service.version in OtlpResource.fromConfig#6299
Open
jrmdayn wants to merge 1 commit into
Open
Conversation
…tlpResource.fromConfig When service.name and/or service.version are set in OTEL_RESOURCE_ATTRIBUTES, fromConfig passed them through to `make`, which also appends them explicitly, producing duplicate KeyValue entries. Filter those keys out of the attributes record before calling `make`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 2446586 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OtlpResource.fromConfigwas duplicating theservice.nameandservice.versionattributes when they were provided through theOTEL_RESOURCE_ATTRIBUTESenvironment variable.The merged attributes record (env + options) was passed straight to
make, which also appendsservice.name/service.versionexplicitly. The result was twoKeyValueentries for each of those keys.This is a problem when using Axiom for example: the collector prints a warning that there are duplicate metric tags.
Fix
Filter
service.name/service.versionout of the attributes record (viaRecord.filter) before handing it tomake, sincemakealready adds them.Test
Added
packages/opentelemetry/test/OtlpResource.test.ts, which setsOTEL_RESOURCE_ATTRIBUTES(including both service keys plus a regular attribute) through a mapConfigProviderand asserts each service key appears exactly once while other attributes are preserved. The first test fails onmain(twoservice.nameentries) and passes with this fix.🤖 Generated with Claude Code