Run SQL statement execution under the sql.execute span - #7493
Open
utopyin wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 9611442 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
utopyin
force-pushed
the
sql-execute-parent-span
branch
from
August 27, 2026 12:23
492035a to
2b7da17
Compare
utopyin
force-pushed
the
sql-execute-parent-span
branch
from
August 27, 2026 12:24
2b7da17 to
9611442
Compare
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
utopyin
marked this pull request as ready for review
August 27, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statement.withConnectionSpancreates thesql.executespan and stampsdb.operation.name/db.query.texton it, but never installs it as the current parent for the connection call it wraps.Anything the connection does while executing attaches to the enclosing span instead: driver HTTP calls picked up by OpenTelemetry
fetchinstrumentation (PlanetScale, Neon, D1) show up as siblings ofsql.execute, andEffect.currentSpaninside aConnectionimplementation resolves to the outer span or nothing.In short, this PR:
Effect.withParentSpan(…, span)on both theacquirerandborrowerpathsStatementtest with a stubConnectionthat recordsEffect.currentSpan; it observesnonebefore this change andsql.executeafterNote: This PR has been generated with AI, I did review the code myself and ensured the patch worked correctly in my own code. Thanks!