fix(atom-solid): forward default idle TTL - #7533
Open
apoorvdarshan wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 9d90ae2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
tim-smart
requested changes
Aug 30, 2026
|
|
||
| describe("atom-solid", () => { | ||
| describe("RegistryProvider", () => { | ||
| it("does not set a default idle TTL", () => { |
Contributor
There was a problem hiding this comment.
You can revert the test addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
@effect/atom-solid'sRegistryProviderpreviously replaced an omitteddefaultIdleTTLwith 400 ms, unlike the React binding and contrary to its forwarding documentation. This change forwardsundefined, allowing unused atom nodes to be removed immediately unless a TTL is explicitly configured.The regression test uses an injected task scheduler to deterministically verify cleanup. It fails with the previous 400 ms fallback and passes with the corrected behavior.
Related
Atom: stream-backed atom's finalizer never runs when consumed via a derived atom andidleTTLexceeds the emission interval #7526@effect/atom-solid: RegistryProvider hardcodesdefaultIdleTTL ?? 400, diverging from@effect/atom-reactand making the TTL impossible to disable #7527Testing
pnpm test --run packages/atom/solid/test/index.test.tsx(11 passed)pnpm lint-fixpnpm lintpnpm checkpnpm exec changeset status(@effect/atom-solidpatch detected)