fix(openapi-generator): declare yaml as a runtime dependency - #7543
Closed
bastiankistner wants to merge 1 commit into
Closed
fix(openapi-generator): declare yaml as a runtime dependency#7543bastiankistner wants to merge 1 commit into
bastiankistner wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🦋 Changeset detectedLatest commit: 9515571 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bastiankistner
force-pushed
the
fix/openapi-generator-yaml-runtime-dependency
branch
from
August 31, 2026 21:06
231b37f to
9515571
Compare
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7542.
openapigenimportsyamlthroughOpenApiPatchduring CLI module loading. Declaring it as a runtime dependency lets strict package managers resolve the import.Worth a close look
pnpmcan mask the problem becauseswagger2openapialso depends onyaml; Yarn Plug'n'Play exposes the undeclared direct import.Verified
pnpm checkpassed.pnpm vitest run --project @effect/openapi-generator: 83 tests passed.pnpm lintpassed.yarn openapigen --helpsucceeds.