Skip to content

Prepare 23.3.4rc1#1566

Draft
psgreco wants to merge 22 commits into
ElementsProject:elements-23.3.xfrom
psgreco:elem-23.3.4rc1
Draft

Prepare 23.3.4rc1#1566
psgreco wants to merge 22 commits into
ElementsProject:elements-23.3.xfrom
psgreco:elem-23.3.4rc1

Conversation

@psgreco

@psgreco psgreco commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Updates master to dee90f2, which fixes CI and enables ELIP 203 by default, also reverts some RPC changes that we don't want in a minor version.

Also cherry-picks #1552

As usual, bump version and update manpages

tomt1664 and others added 17 commits April 7, 2026 14:59
…py to fix intermittent failure

6515f58 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan)

Pull request description:

  Prevents blinded output being selected intermittently and resulting in vszie and fee assertions failing.

ACKs for top commit:
  delta1:
    ACK 6515f58; fixes discount_ct test flakiness

Tree-SHA512: 32d8c64011125e5531dd19ce84dbe39b2d4496a02c5bf5ece0cbc2f0c2bf6660816d6d61593fe32a615dd96a8632d94cba6bc09e792ffa6ea57fbdc4f52424da
72e4e1c use break-system-packages for pip (Tom Trevethan)

Pull request description:

  Add --break-system-packages to PIP_PACKAGES in macos CI, to allow for macos-runner images to update homebrew packages.

ACKs for top commit:
  delta1:
    ACK 72e4e1c; fixes macos ci task

Tree-SHA512: 27dc712309940afde1d21c9f465c244eb49d0d1bb8bbf2faba3bf64d00a63f975943825019cd45f1c32e462ab6b5d74490cb0876aeb5e6397da20e668fff2823
… liquidtestnet

60a97d1 Enable ELIP203 by default in liquidv1 (Pablo Greco)
7577eb9 Enable ELIP203 by default in liquidtestnet (Pablo Greco)

Pull request description:

ACKs for top commit:
  tomt1664:
    ACK ElementsProject@60a97d1
  delta1:
    ACK 60a97d1

Tree-SHA512: 4bd3840f6c09db5100d58f7ca6d97be6923b0f7fbcad3855c6bb0d2139e8d44e0baab0aaffd00a1cd4f2073d5bb5abdfdbe16a249f68fd2213972531512d3153
a189d63 add release note for datacarriersize default change (Greg Sanders)
a141e1b Add more OP_RETURN mempool acceptance functional tests (Peter Todd)
0b4048c datacarrier: deprecate startup arguments for future removal (Greg Sanders)
63091b7 test: remove unnecessary -datacarriersize args from tests (Greg Sanders)
9f36962 policy: uncap datacarrier by default (Greg Sanders)

Pull request description:

  Retains the `-datacarrier*` args, marks them as deprecated, and does not require another startup argument for multiple OP_RETURN outputs.

  If a user has set `-datacarriersize` the value is "budgeted" across all seen OP_RETURN output scriptPubKeys. In other words the total script bytes stays the same, but can be spread across any number of outputs. This is done to not introduce an additional argument to support multiple outputs.

  I do not advise people use the option with custom arguments and it is marked as deprecated to not mislead as a promise to offer it forever. The argument itself can be removed in some future release to clean up the code and minimize footguns for users.

Tree-SHA512: 3da2f1ef2f50884d4da7e50df2121bf175cb826edaa14ba7c3068a6d5b2a70beb426edc55d50338ee1d9686b9f74fdf9e10d30fb26a023a718dd82fa1e77b038
(cherry picked from commit 983cf90)
Reverts commit 0b4048c

(cherry picked from commit b521a1b)
This reverts commit fecf4f1.
This reverts commit 8408b79.
@psgreco psgreco changed the title Elem 23.3.4rc1 Prepare 23.3.4rc1 Jun 29, 2026
tomt1664 added 2 commits June 29, 2026 08:53
(cherry picked from commit 09d9486)
(cherry picked from commit 0331feb)
@psgreco psgreco requested review from delta1 and tomt1664 June 29, 2026 15:57
@psgreco psgreco self-assigned this Jun 29, 2026

@delta1 delta1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 87a57e7; tested locally

@tomt1664

Copy link
Copy Markdown
Member

Tested ACK 87a57e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants