renepay: skip channels disabled in gossmap#9134
Open
cdecker wants to merge 1 commit into
Open
Conversation
channel_is_available() checked whether a channel_update existed (gossmap_chan_set) and whether renepay's own disabledmap had flagged it, but never checked gossmap's half_chan.enabled flag. This meant renepay would route through channels marked disabled in the gossip_store, wasting HTLC round-trips to re-discover the failure. Changelog-Fixed: renepay now skips channels disabled in the gossip map.
Lagrang3
approved these changes
May 14, 2026
Collaborator
Lagrang3
left a comment
Lagrang3
left a comment
There was a problem hiding this comment.
This should work as you have described.
askrene already checks if the channel is available.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channel_is_available()checkedgossmap_chan_set()(channel_update exists) and renepay's owndisabledmapbitmap, but never checked gossmap'shalf_chan.enabledflagchan->half[dir].enabledin its equivalent code pathChangelog-Fixed: renepay now skips channels disabled in the gossip map.
Test plan
make plugins/cln-renepaybuilds cleanly