dual-fund/splice: mark superseded RBF/splice inflight candidates, stop recomputing their commitments - #9448
Draft
Andezion wants to merge 2 commits into
Draft
Conversation
…ommitsig persistence Changelog-None
…roject#9373-class RBF race Changelog-None
Andezion
force-pushed
the
splice-superseded-inflights
branch
from
August 26, 2026 10:49
330c26a to
de4018c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9373 ("dualopend: reconnect during block catch-up locks in the
wrong RBF inflight", fixed in 90b58e8 / 31d08fb). That fix made
lightningd record the winning
channel_inflightas soon as its block isseen, instead of waiting for chain catch-up to finish - closing a window
where a reconnecting peer could lock in against a funding tx that was never
mined
TODO
candidates (not just lightningd persisting them) would require channeld
to drop the candidate from its own
splice_state->inflightsandrenegotiate the commit-sig batch size with the peer???
splice_depth_cb()(channel_control.c) only notifies channeld of areached confirmation depth
if (channel->owner). If the depth thresholdis reached while the peer is disconnected, that notification is silently
dropped and isn't resent until the next new block (self-healing, but
can delay splice lock-in by up to one confirmation after a disconnect)
Testing
wallet/test/run-wallet(DB round-trip unit test) - passtests/test_opening.py -k rbf(15 tests, including the extendedtest_rbf_reconnect_non_last_minedwhich now asserts losing inflightsend up
superseded) - passtests/test_splicing.py(full suite, 13 tests) - passmake check-whitespace check-spelling- cleanImportant
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade