Skip to content

ci: replace unmaintained katyo/publish-crates with a native cargo publish step #9635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daywalker90 wants to merge 1 commit into
base: master
Choose a base branch
from
+47 −20
Open

ci: replace unmaintained katyo/publish-crates with a native cargo publish step #9635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 47 additions & 20 deletions .github/workflows/crate-io.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,56 @@ on:
branches:
- "master"

permissions:
contents: read

jobs:
release_rust:
runs-on: ubuntu-22.04
timeout-minutes: 30
steps:
- uses: actions/checkout@v6
- uses: dtolnay/rust-toolchain@stable
- uses: katyo/publish-crates@v2
with:
path: './cln-rpc'
registry-token: ${{ secrets.CARGO_REGISTRY_TOKEN }}
ignore-unpublished-changes: true
- uses: katyo/publish-crates@v2
with:
path: './plugins'
registry-token: ${{ secrets.CARGO_REGISTRY_TOKEN }}
ignore-unpublished-changes: true
- uses: katyo/publish-crates@v2
with:
path: './cln-grpc'
registry-token: ${{ secrets.CARGO_REGISTRY_TOKEN }}
ignore-unpublished-changes: true
- uses: katyo/publish-crates@v2
with:
path: './lsps-types'
registry-token: ${{ secrets.CARGO_REGISTRY_TOKEN }}
ignore-unpublished-changes: true
- name: Publish crates whose git version is newer than crates.io
env:
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
run: |
set -euo pipefail
# Dependency order: each crate comes after the in-repo crates it depends on.
for dir in cln-rpc cln-grpc plugins lsps-types; do

@Andezion Andezion Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script publishes only if local > max(published). Suppose someone bumps an older line, cln-rpc 0.6.1 after 0.7.0 is out. that version is skipped silently with "already has an equal or newer version"?, but it was never published. maybe we can use smth like katyo/publish-crates, it checks whether the exact version exists? what do you think

@daywalker90 daywalker90 Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of this PR is to get rid of katyo/publish-crates. We have never gone back and published a patch version for an older "minor" version, not sure if we ever need that.

metadata=$(cargo metadata --no-deps --format-version 1 --manifest-path "$dir/Cargo.toml")

@Andezion Andezion Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to check manifest_path?
maybe add

            [ -n "$pkg" ] || { echo "no package found in $dir"; exit 1; }

@daywalker90 daywalker90 Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the manifest path for cargo publish and the package name might be non-existent in $dir, e.g. there is no cln-plugin directory, the directory is called plugins and the package cln-plugin.

pkg=$(jq -r --arg m "$PWD/$dir/Cargo.toml" \
'.packages[] | select(.manifest_path == $m) | "\(.name) \(.version)"' <<< "$metadata")
name=${pkg% *}
version=${pkg#* }
decision=$(python3 - "$name" "$version" <<'EOF'
import json, sys, urllib.error, urllib.request

def semver_key(v):
core, _, pre = v.split("+")[0].partition("-")
nums = tuple(int(x) for x in core.split("."))
if not pre:
return nums, 1, ()
ids = tuple((0, int(i), "") if i.isdigit() else (1, 0, i) for i in pre.split("."))
return nums, 0, ids

name, local = sys.argv[1], sys.argv[2]
url = f"https://index.crates.io/{name[:2]}/{name[2:4]}/{name}"
try:
with urllib.request.urlopen(url, timeout=30) as resp:
published = [json.loads(line)["vers"] for line in resp.read().decode().splitlines() if line]
except urllib.error.HTTPError as err:
if err.code != 404:
raise
published = []
newer = not published or semver_key(local) > max(semver_key(v) for v in published)
print("publish" if newer else "skip")
EOF
)
if [ "$decision" = "publish" ]; then
echo "Publishing $name $version from $dir"
cargo publish --manifest-path "$dir/Cargo.toml"
else
echo "Skipping $name $version: crates.io already has an equal or newer version"
fi
done
Loading