Repository navigation
Reload the page in the event of a Cloudflare challenge - #1395
Merged
Merged
Conversation
It doesn't work with turbolinks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change that handles Cloudflare Managed Challenges with full-page navigation.
No open issues 🎉
What changed in this PR
This PR adds full-page navigation when Cloudflare returns a Managed Challenge during a Turbolinks request, addressing blank pages caused by the application’s Content Security Policy blocking the challenge response.
Changes:
- Checks the
cf-mitigatedresponse header when a Turbolinks request ends. - Navigates to the response URL, falling back to the current URL, so the challenge loads with its own headers.
| File | Description |
|---|---|
app/assets/javascripts/application.js |
Adds challenge detection and full-page navigation to the Turbolinks request-end handler. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
The CSP was blocking such responses when they are loaded as part of a turbolinks request, e.g. if the user is applying filters, and they would just see a blank page.
Checklist