Skip to content

fix: require approval for material strategic revisions - #286

Merged
EvanProgramming merged 30 commits into
mainfrom
Evan/v3-246-plan-reapproval
Oct 17, 2026
Merged

EvanProgramming merged 30 commits into
mainfrom
Evan/v3-246-plan-reapproval

Conversation

@EvanProgramming

@EvanProgramming EvanProgramming commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

Require fresh user approval before material Strategic Plan revisions while allowing changes that remain inside approved objectives, acceptance criteria, workspace, effects, capabilities, and risk.

Implements #246 (R074–R076, R078), stacked on #285 / issue #245.

Changes

  • Stage material revisions without replacing the accepted plan; pause new mutations until approval, while keeping cancellation available.
  • Bind acceptance to plan ID, version, fingerprint, and Working Plan revision; apply the linked task changes and approval event atomically.
  • Preserve completed tasks and evidence only when the revised objective, acceptance, execution contract, and verification evidence still match.
  • Recheck accepted bounds at shared and delegated execution boundaries.
  • Close five prior follow-up findings and three final findings: exact file path authorization; transactional completion by plan/version/fingerprint; and preservation of restored pending proposals during auto-accept.
  • Include the current [V3] Preserve Plan Mode with versioned, user-approved Strategic Plans #245 head in the branch with signed merge commits; no published history was rewritten.

Validation

  • PASS: tests.test_interaction (94 tests) and the full Python 3.12 suite (903 tests).
  • PASS: make check, make lint, make docs-check, git diff --check, and Go TUI tests.
  • PASS: final-head GitHub Actions run 39007288885: Python 3.12/3.13 full suites, Docker persistence, wheel install, TUI, installer syntax, and installed-update checks on Ubuntu/macOS/Windows. The separate core-test job was skipped by workflow path filtering.
  • PASS: GitHub verified the latest GPG-signed head commit 34e3b34.
  • PASS: all 14 inline review threads are resolved.
  • REVIEW: existing Codex findings are fixed and resolved; CodeRabbit skipped this stacked base branch. No new final-head review submission has arrived.

No paid provider calls or new dependencies. Leave this PR and #246 open and unmerged pending confirmation.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7f701b1d-7273-4aed-934b-cf26f3969313
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

@codex review

@coderabbitai review

Please review the final head b51e602, with particular attention to the strategic file-write fallback and legacy pipe-delimited argument handling.

@ghfind-review ghfind-review Bot added review: high ghfind author score; see https://ghfind.com area: security Capabilities, approvals, scope boundaries, and OS sandboxing bug Something isn't working enhancement New feature or request labels Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T02:25:05.159866Z 9de73cd Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b51e602479

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread openkyrozen/agent/modes.py Outdated
Comment thread openkyrozen/agent/executor.py
Comment thread openkyrozen/agent/executor.py
Comment thread openkyrozen/agent/modes.py Outdated
Comment thread openkyrozen/agent/modes.py
Comment thread openkyrozen/agent/executor.py

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea5a9ac771

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread openkyrozen/agent/modes.py Outdated
Comment thread openkyrozen/agent/modes.py
Comment thread openkyrozen/agent/modes.py
Comment thread openkyrozen/agent/modes.py
Comment thread openkyrozen/agent/executor.py

Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9de73cdcf0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread openkyrozen/agent/executor.py
Comment thread openkyrozen/agent/modes.py
Comment thread openkyrozen/persistence/events.py Outdated
@EvanProgramming
EvanProgramming changed the base branch from Evan/v3-245-strategic-plans to main October 17, 2026 07:43
@EvanProgramming
EvanProgramming merged commit 48ba782 into main Oct 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: security Capabilities, approvals, scope boundaries, and OS sandboxing bug Something isn't working enhancement New feature or request review: high ghfind author score; see https://ghfind.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant