Repository navigation
[LegendList 5/9] refactor: prepare report list refs and recycled row state - #104978
Draft
chrispader wants to merge 1 commit into
Draft
chrispader wants to merge 1 commit into
chrispader wants to merge 1 commit into
Conversation
Share the report list imperative contract while retaining a compatibility export for inverted FlashList. Keep row-local preview state tied to its action and let money-report edit scroll requests survive until the list commits its layout. Co-authored-by: Codex <noreply@openai.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This was referenced Oct 26, 2026
Contributor
Author
|
@MelvinBot request review from @roryabraham and @dmkt9 and assign them here. |
Contributor
|
Done. I requested reviews from |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message rows can be reused for another action, and the shared list ref still describes a legacy FlatList. This PR adds a common ref contract and prepares row and preview state for reuse. It also lets money reports finish edit scrolling after the list layout commits.
@roryabraham @dmkt9
Explanation of Change
This is layer 5 of the nine-part LegendList series, extracted from #100733. It is independent of layer 4. The main chat continues to use inverted FlashList; layer 6 introduces LegendList rendering. A temporary type export keeps the existing FlashList wrapper compatible until that migration removes it. Closing an edit in the main chat now calls the scroll manager's
scrollToBottominstead ofscrollToIndex(0), so on web the list jumps to the newest message instead of animating.Review and merge order: nine-part LegendList rollout. Layers 4 and 5 are independent preparations; merge both before layer 6.
Fixed Issues
$ #98994
Part of the migration split from #98270. No approved proposal is linked.
Tests
All platforms means desktop web, mobile web, Android, and iOS.
All platforms, attachment previews after scrolling
All platforms, switching expense reports
All platforms, save a short expense-report comment
one.two.All platforms, cancel an expense-report comment edit
Keep me.All platforms, delete a comment through the editor
Delete me.All platforms, edit the newest chat message
All platforms, repeated link previews
Offline tests
All platforms, save a cached comment offline
Offline edit.All platforms, attachment previews offline
QA Steps
Run the All platforms cases and the blocks for the platform being tested, including Offline tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari