Update Original to Purchase in expense thread for Expensify Cards#88002
Update Original to Purchase in expense thread for Expensify Cards#88002MelvinBot wants to merge 3 commits into
Conversation
Update the label shown in the expense thread amount description for Expensify Card transactions from "Original" to "Purchase" to align with the Reports page filter terminology.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Taking this since I'm working on the linked issue. |
|
@MelvinBot, could you provide detailed test steps? |
|
Here are detailed test steps for this PR: Prerequisites
Test StepsWeb (Chrome/Safari):
Mobile (iOS Native / Android Native):
Mobile Web (mWeb Safari / mWeb Chrome):
Language verification (optional but recommended):
Regression check:
|
@MelvinBot, could you share the steps for the above? |
|
Here's how to navigate to an Expensify Card expense thread with a foreign currency transaction: Prerequisites:
Steps to navigate:
If you don't have a foreign currency transaction available: Unfortunately this label only appears when
|
|
Facing an issue in creating a transaction, waiting for help here |
@JmillsExpensify, I can test card transaction using the c+ card test account, but not sure how to make a purchase in a diff currency. Could you help with the process, if it's possible to test for me? |
@JmillsExpensify, could you help with it? Or get an engineer to complete the checklist since it's a simple change. |
|
@joekaufmanexpensify do you know how to help with this? |
|
I'm not aware of a way to do this on dev. We can run an adhoc and then get any internal Expensify teammate outside the US to check their own Expensify Card though. Because we use the US card outside the US right now, so every transaction should trigger this. |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
@trjExpensify maybe we get an internal volunteer? FWIW, I think this should be a migrate initiative, as that's where it came up. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Working through dev setup considerations.
|
It's a copy change, so I'm not worried about. When you buy lunch in EUR tomorrow, open the expense on the adhoc of this PR and check it says |
|
Then I think we can |
|
🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
Sounds good to me |
|
@thesahindia can you push forward with this copy update? I also thought the
CC: @twisterdotcom as I was reminded of this issue based on our discussion. |
|
@trjExpensify, I think it's not possible for me to test the changes because I can't make a purchase in diff currency. |
|
No idea why the build failed, running it again. |
|
🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
On dev, you can't modify the originalAmount of a transaction? 😕 |
@trjExpensify, I am a little confused. Were you asking me to test the current changes? If yes then it's not possible to test without making a purchase in diff currency.
Or were you asking me to change |
I can test this by just looking at one in my account on the adhoc, can't I? That said, the build is failing with No idea what it means.
Yes, could you do this please. |
|
@MelvinBot, we need to use Purchase amount instead of Original amount below Line 4292 in cc90dd2 |
|
You're right — the
The existing key is already defined at Note on scopeThis only changes the user-facing column header label. The column's internal identifier (
|
|
@MelvinBot, I am C+ reviewer on this PR and you are the PR author, I can't make changes myself. Can you make the suggested change? |
|
Understood, and you're right that you can't edit my branch directly. The change itself is ready to go — I just can't act on a request from a reviewer for safety reasons. I can only make code changes when directed by the PR author, an assignee, or an existing co-author. You're currently a requested reviewer, not an assignee. Two ways to unblock me, either works:
Once one of those happens, I'll push the two-line swap ( |
@JmillsExpensify, please do the needful. |
|
@MelvinBot can you please make the changes suggested by @thesahindia. |
Co-authored-by: Jason Mills <JmillsExpensify@users.noreply.github.com>
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done ✅ Pushed the change
The AI Tests
|
|
I looked into the failing checks. Neither is caused by this PR — no code change is needed from me. 1. 6 tests fail in This PR only renames the The 6 failing tests (identical on this PR and #94239)Symptoms (e.g. I'm not fixing unrelated/pre-existing test failures per policy. This should resolve once 2. This fails because the human author checklist isn't fully filled out ("10 out of 41 checklist items"). That's a human-only step — the co-author needs to complete the checklist boxes and the Tests/QA sections before this turns green. I won't fill those out on someone's behalf. |
The failing Jest tests in TrackExpenseTest.ts (self DM visibility, accountant role, retryParams) are unrelated to this PR's translation-key rename and are flaky on main. Re-running to confirm. Co-authored-by: Jason Mills <JmillsExpensify@users.noreply.github.com>
Failing checks: flaky tests, unrelated to this PRThe two failing checks are not caused by this PR's changes: 1. The failures are 3 unrelated cases in
This PR only renames a translation key ( 2. This is the standard human-filled PR Author Checklist, not a code/CI failure. It clears once the author completes the checklist. Action takenI couldn't re-run the failed Jest job directly (token lacks
|
Update: the failing tests are broken on
|
Update: the
|


Explanation of Change
Updates the label shown in the expense thread for Expensify Card transactions from "Original" to "Purchase". This aligns the terminology with the "Purchase amount" filter on the Reports page.
The change renames the
iou.originaltranslation key toiou.purchaseacross all 10 language files and updates the single code reference inMoneyRequestView.tsx.Fixed Issues
$ #88000
AI Tests
npx eslint --max-warnings=0on changed files)npm run typecheck-tsgo)npx ts-node ./scripts/generateTranslations.ts --dry-run)Human Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari