[Rules Revamp R1] Add tabbed Rules page layout and restructure General tab

[Krishna2323]

Explanation of Change

Fixed Issues

$ #92739
PROPOSAL:

Tests

• Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

• Same as QA Steps

QA Steps

Prerequisites

• Should have access to rulesRevamp beta.

Beta gate

1. With beta off → legacy rules page (no tabs).
2. With beta on → tabbed revamp (General / Card restrictions / Expense defaults, + Rule).

General tab

1. Confirm titles: Flag expenses older than, Flag expenses above amount, Flag receipt line items, Require receipts, Require fields…
2. Open each row → RHP title matches; save a change → row description updates.

Flag receipt line items

1. Toggle without saving → not persisted on return.
2. Toggle + Save → persisted.
3. Offline: save → only changed toggles grey out; General tab row greys out; clears after sync.

Require receipts

1. Enable toggle, leave amount empty, save → field error + form alert; fix the errors focuses first invalid field.
2. Both toggles on with receipt amount > itemized amount → errors on both fields.
3. Offline: change only one toggle/amount + save → only that row greys out (not the other).

Require fields / Cash / Billable

1. Change toggles or selection → Save → persists and General tab updates.
2. Offline: pending grey-out on changed row + parent General tab row.

Card restrictions & Expense defaults tabs

1. Tables render with correct columns/badges; edit + save updates table.
2. Bulk select + delete works.
3. Card restrictions shows upsell when card not enabled.

+ Rule flows

1. Restrict card spend and Apply expense defaults — create/edit/save from + Rule.

Regression

1. eReceipts + attendee tracking toggles still save with offline pending feedback.
2. Legacy page unchanged when beta is off.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[JS00001]

@luacmartins over to ya

[luacmartins]

Left a couple of NAB. Additionally, we have a beta for this feature so can we please break future PRs into smaller incremental changes? That'll make reviewing much easier and faster.

[luacmartins]

NAB but we should rename these files and remove the Revamp from the name

[luacmartins]

This seems legit. Are we gonna address this in a follow up?

[github-actions]

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

[cead22]

I see this was just moved from below, but can we get rid // eslint-disable-next-line no-nested-ternary with if/else?

[cead22]

NAB but I think "spend" can be interpreted as multiple expenses, whereas "expense" is clear that it's just one (though maybe that's the intention)

[cead22]

NAB: Is the Revamp part of the filenames temporary? If not, can we use something that won't get outdated? Same goes for types like SpendRuleRestrictionTypeToggleRevampProps, "NewPage" in src/pages/workspace/rules/RulesNewPage.tsx and everything else

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93185.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1b00f942f83-9980e46-a99965009c6649760b68c0f00f1600c0664adf43/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1b00f94-9980e46-3d02c91b862f76691c37320725eecb608b5bc619/index.html

Web 🕸️
https://93185.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

Help site review — docs update needed

Yes, this PR requires help site changes. It restructures the workspace Rules page into tabs (General / Card restrictions / Expense defaults) and renames the General tab rows, which the existing Workspace Rules article does not reflect.

Draft help site PR: #94232

What changed and what I updated

The article's How to configure Expense Rules section described the legacy single-page layout (e.g. "Max expense amount", "Max expense age", "Prohibited expenses"). I updated it to describe the revamped layout, with labels verified against the merged English copy in src/languages/en.ts:

• Three tabs: General, Card restrictions, Expense defaults
• Add rule button → Restrict card spend / Apply expense defaults
• General tab rows: Flag expenses older than, Flag expenses above amount, Flag receipt line items, Require receipts, Require fields for all expenses, Cash expenses, Billable expenses, plus eReceipts and Attendee tracking

⚠️ Beta-gated / phased rollout: This change is behind the rulesRevamp beta and is R1 of a multi-part revamp. With the beta off, users still see the legacy Rules page. The draft is intentionally not ready for review — it shouldn't be merged until the revamp reaches GA, and may need follow-up updates as later releases land.

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review.

[m-natarajan]

@Krishna2323 @situchan @cead22 @luacmartins @JS00001 Is expensifail account have access to rulesRevamp beta.?

Expected Rules page not diaplayed for expensifail account.

[luacmartins]

@m-natarajan I just added @applause.expensifail.com to the beta

[jponikarchuk]

Deploy Blocker #94352 was identified to be related to this PR.

[jponikarchuk]

Deploy Blocker #94353 was identified to be related to this PR.

[jponikarchuk]

Deploy Blocker #94356 was identified to be related to this PR.

[jponikarchuk]

Deploy Blocker #94360 was identified to be related to this PR.

[OSBotify]

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[OSBotify]

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[mitarachim]

Deploy Blocker #94383 was identified to be related to this PR.

[mitarachim]

Deploy Blocker #94384 was identified to be related to this PR.