Do a sparse checkout for the validate mobile expensify submodule workflow#94196
Do a sparse checkout for the validate mobile expensify submodule workflow#94196iwiznia wants to merge 4 commits into
Conversation
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eda37920ad
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| token: ${{ secrets.OS_BOTIFY_TOKEN }} | ||
| # We only read the default-branch HEAD SHA (git rev-parse HEAD), never file contents, | ||
| # so skip downloading blobs and check out only the repo root to avoid materializing the tree. | ||
| filter: blob:none |
There was a problem hiding this comment.
Remove the filter that overrides sparse checkout
In this Checkout Mobile-Expensify step, setting filter prevents the sparse patterns from being applied: the Blacksmith checkout docs preserve upstream checkout behavior and document the filter input as “Overrides sparse-checkout if set.” In this workflow, that means sparse-checkout: . is ignored and the full Mobile-Expensify worktree is still checked out under .github/mobile-expensify-repo, so the intended validation speedup is lost whenever the submodule workflow runs; use sparse checkout without the overriding partial-clone filter, or otherwise avoid combining these two inputs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This was a test to see how fast it run, I re-added it already
Explanation of Change
Context https://expensify.slack.com/archives/C03TQ48KC/p1782141021512849?thread_ts=1782138918.551879&cid=C03TQ48KC
This workflow does not need the full repo, so doing a sparse clone should speed it uyp
Tests
Ran the GH action. Before:


After:
Offline tests
No
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
No
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari