Update the policy taxes table to the new style#94208
Conversation
Extract taxes table row and table wrapper using the shared Table component pattern.
Replace SelectionListWithModal with the shared Table component while preserving bulk actions, search, and row interactions.
melvin-bot
Bot
requested review from
Krishna2323,
joekaufmanexpensify and
situchan
and removed request for
a team
|
@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 683227a349
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
This is not ready for review yet |
Skip mobile row-tap selection when item.disabled is true, matching checkbox behavior and preserving the default tax rate guard.
|
Ready for review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e4629165c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
input_focus_lost.mp4
cursor_select_shown.mp4 |
| return Object.entries(policy.taxRates?.taxes ?? {}).map(([key, value]) => { | ||
| const canEditTaxRate = canWriteTaxes && policy && canEditTaxRatePolicyUtils(policy, key); | ||
| const canEditTaxRate = canWriteTaxes && canEditTaxRatePolicyUtils(policy, key); | ||
| const isDeleting = value.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE; |
There was a problem hiding this comment.
Shouldn't we just filter out the pending-delete items in online mode, similar to how the Categories page does it?
2 participants
Explanation of Change
Migrate the policy taxes page to the shared
Tablecomponent.Fixed Issues
$ #86208
Tests
Screen.Recording.2026-06-22.at.3.28.54.PM.mov
Offline tests
N/A
QA Steps
Same as tests