[No QA] Fix iOS complete_hybrid_rollout crash by passing APPLE_ID env#94243
Open
blimpich wants to merge 3 commits into
Open
[No QA] Fix iOS complete_hybrid_rollout crash by passing APPLE_ID env#94243blimpich wants to merge 3 commits into
blimpich wants to merge 3 commits into
Conversation
This reverts commit ce45109.
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@nyomanjyotisa please ignore the ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
TLDR: A deploy step that pushes the previous iPhone app version out to 100% of users has been quietly crashing on every release for ~15 months, because it was told to look up our app using a setting that was never filled in.
What happens, simply:
The step asks Apple "which app has this ID?" — but the ID is blank, so Apple finds nothing, and the step crashes trying to use that "nothing."
Nobody noticed because this step is set to "keep going even if it fails," so the deploy still went green. And Apple finishes the rollout on its own after about a week anyway, so users were never affected — it just meant we weren't doing that final step ourselves.
Why the ID was blank: PR #59000 (March 2025, "Add iOS and Android Parameterization") stopped typing our app's ID directly into the deploy scripts and switched to reading it from a setting (
APPLE_ID) instead. It added that setting to the other deploy steps that use it — but missed this "push to 100%" step. So this one step has been reading a blank ID ever since.The fix: Fill in the missing
APPLE_IDsetting on the step — one line, copied from the neighboring step that already works.Fixed Issues
$ #94241
PROPOSAL:
Tests
Only runs during a production deploy, so it can't be tested in the app or dev environment. It'll be confirmed on the next iOS production deploy: the "Submit previous production build to 100%" step should finish cleanly with no crash / red error.
Offline tests
N/A — CI deploy-pipeline change only.
QA Steps
Same as tests. CI-only change; not testable on staging. Title is prefixed
[No QA].PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — CI deploy-pipeline change (
deploy.yml), no UI.– written by Claude on Ben's behalf