Skip to content

[No QA] Fix iOS complete_hybrid_rollout crash by passing APPLE_ID env#94243

Open
blimpich wants to merge 3 commits into
mainfrom
blimpich-fixIosCompleteHybridRolloutCrash
Open

[No QA] Fix iOS complete_hybrid_rollout crash by passing APPLE_ID env#94243
blimpich wants to merge 3 commits into
mainfrom
blimpich-fixIosCompleteHybridRolloutCrash

Conversation

@blimpich

@blimpich blimpich commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

TLDR: A deploy step that pushes the previous iPhone app version out to 100% of users has been quietly crashing on every release for ~15 months, because it was told to look up our app using a setting that was never filled in.

What happens, simply:

The step asks Apple "which app has this ID?" — but the ID is blank, so Apple finds nothing, and the step crashes trying to use that "nothing."

Step asks Apple: "find the app with ID = (blank)"  →  Apple: "no app found"  →  step crashes

Nobody noticed because this step is set to "keep going even if it fails," so the deploy still went green. And Apple finishes the rollout on its own after about a week anyway, so users were never affected — it just meant we weren't doing that final step ourselves.

Why the ID was blank: PR #59000 (March 2025, "Add iOS and Android Parameterization") stopped typing our app's ID directly into the deploy scripts and switched to reading it from a setting (APPLE_ID) instead. It added that setting to the other deploy steps that use it — but missed this "push to 100%" step. So this one step has been reading a blank ID ever since.

The fix: Fill in the missing APPLE_ID setting on the step — one line, copied from the neighboring step that already works.

Fixed Issues

$ #94241

PROPOSAL:

Tests

Only runs during a production deploy, so it can't be tested in the app or dev environment. It'll be confirmed on the next iOS production deploy: the "Submit previous production build to 100%" step should finish cleanly with no crash / red error.

  • Verify that no errors appear in the JS console

Offline tests

N/A — CI deploy-pipeline change only.

QA Steps

Same as tests. CI-only change; not testable on staging. Title is prefixed [No QA].

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — CI deploy-pipeline change (deploy.yml), no UI.

– written by Claude on Ben's behalf

@blimpich blimpich changed the title [No QA] Guard nil app/version in iOS complete_hybrid_rollout to prevent deploy crash [No QA] Fix iOS complete_hybrid_rollout crash by passing APPLE_ID env (+ defensive nil guards) Jun 23, 2026
@blimpich blimpich changed the title [No QA] Fix iOS complete_hybrid_rollout crash by passing APPLE_ID env (+ defensive nil guards) [No QA] Fix iOS complete_hybrid_rollout crash by passing APPLE_ID env Jun 23, 2026
@blimpich blimpich marked this pull request as ready for review June 23, 2026 01:45
@blimpich blimpich requested a review from a team as a code owner June 23, 2026 01:45
@melvin-bot melvin-bot Bot requested review from truph01 and removed request for a team June 23, 2026 01:45
@melvin-bot

melvin-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@blimpich blimpich requested review from a team and Julesssss and removed request for truph01 June 23, 2026 01:45
@melvin-bot melvin-bot Bot requested a review from nyomanjyotisa June 23, 2026 01:45
@melvin-bot

melvin-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team June 23, 2026 01:45
@blimpich blimpich removed the request for review from nyomanjyotisa June 23, 2026 01:45
@blimpich

Copy link
Copy Markdown
Contributor Author

@nyomanjyotisa please ignore the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant