Skip to content

fix: add explicit discard for unpushed cleanup worktrees#742

Merged
chubes4 merged 2 commits into
mainfrom
fix/737-discard-unpushed-cleanup
Jun 16, 2026
Merged

fix: add explicit discard for unpushed cleanup worktrees#742
chubes4 merged 2 commits into
mainfrom
fix/737-discard-unpushed-cleanup

Conversation

@chubes4

@chubes4 chubes4 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Add explicit --discard-unpushed / discard_unpushed support for bounded cleanup-eligible apply so operators can intentionally discard unpushed commits without weakening --force.
  • Preserve default safety: unpushed cleanup-eligible worktrees are still skipped unless the new data-loss flag is present.
  • Emit exact discard evidence, including handles, unpushed counts before removal, and path-exists-after status.

Fixes #737.

Verification

  • php -l inc/Workspace/WorkspaceWorktreeCleanupEngine.php && php -l inc/Cli/Commands/WorkspaceCommand.php && php -l inc/Abilities/WorkspaceAbilities.php && php -l inc/Tasks/WorktreeCleanupChunkTask.php && php -l tests/smoke-worktree-bounded-cleanup-eligible-apply.php && php -l tests/smoke-worktree-cleanup-cli.php
  • php tests/smoke-worktree-bounded-cleanup-eligible-apply.php
  • php tests/smoke-worktree-cleanup-cli.php

@homeboy-ci

homeboy-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine-code --changed-since 2519ac3

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27585416317

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Save test baseline: homeboy test data-machine-code --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since 2519ac3

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27585416317

Audit

audit — passed

  • audit — 51 finding(s)
  • Total: 51 finding(s)

Deep dive: homeboy audit data-machine-code --changed-since 2519ac3

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27585416317
Tooling versions
  • Homeboy CLI: homeboy 0.232.0+8fd2b92d870e+35bd476
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 97d0a4d2
  • Action: unknown@unknown

@chubes4 chubes4 merged commit a52de95 into main Jun 16, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/737-discard-unpushed-cleanup branch June 16, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup force mode needs an operator-approved discard path for cleanup-eligible worktrees

1 participant