Repository navigation
Give a directory domain its own join account - #41
Merged
Merged
Conversation
A domain can now carry the account its hosts join with (FOGProject/fogproject#1887). The plugin answers core's DIRECTORY_JOIN_ACCOUNT event, so the FOG Client, the Agent and FOS all get the domain's account. A domain with no account leaves the host's own ADUser/ADPass in place. - steps 8 and 9 add ddJoinUser and ddJoinPwd to directoryDomains; - Join Username and Join Password on the domain page; a blank password keeps the stored one on edit; - joinPwd is in the API's `always` tier and is dropped from the export. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For FOGProject/fogproject#1887. Needs FOGProject/fogproject#1890, which adds the
DIRECTORY_JOIN_ACCOUNTevent.Change
ddJoinUserandddJoinPwd, added by schema steps 8 and 9.DIRECTORY_JOIN_ACCOUNT. The domain's account beats the host's ownADUser/ADPass. A domain with no account (user and password both needed) leaves the host's own in place.joinPwdis in the API'salwayssensitive tier and is dropped from the CSV export, likebindPwd.Test
tests/directorygroups-join-account.test.php: the account rule, the listener registration, the API strip and the export strip, and the ALTER steps. It fails with the strip removed. Suite: 20 passed.🤖 Generated with Claude Code