[failproofai-feat-failproofai-cloud-login] Sign in to fp from a browser

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## 1.0.14-beta.0 — 2026-11-02
 
+### Features
+
+- `fp login` can sign you in from a browser, as `failproofai config` does: on a terminal it starts on a link, Tab switches to a code by email, and either way you get your own session. New deliberate-run harness: `__tests__/e2e/layout/fp-login.sh`. (#981)
+
 ### Docs
 
 - Add public pages for the MCP server, the Slack app and product analytics, which the assistant and MCP server can now answer from (#982).

__tests__/e2e/layout/README.md

@@ -10,6 +10,7 @@ not depend on — so they are invoked deliberately.
 | `cloud-collector.sh` | an AgentEye stack | real connect against a live server, daemon + collector writing layout-2 paths, decisions reaching ClickHouse, disconnect back to OSS |
 | `systemd-service.sh` | Docker | REAL `systemctl enable --now` as root in a privileged container: service lifecycle, fail-closed, self-heal, reinstall |
 | `cli-login.sh` | an AgentEye stack (dashboard + mailpit + its Postgres), an older Cloud server without `/api/auth/cli/*` routes, Docker, `bun run build` + the release daemon | `config`'s browser login through a real pty in a systemd container: approve, re-login, deny + retry, abandon after approval (no key minted), esc, expiry, revoked saved key, older server, and the person-side refusals (Origin, form posts, no session, start rate limit) |
+| `fp-login.sh` | an AgentEye stack (dashboard + mailpit + its containers), `uv sync` in `fp-cloud-cli`; optionally a Cloud with `config`'s login but not `fp`'s, and a dashboard with `DASHBOARD_TRUSTED_INGRESS=1` | `fp login`'s browser flow through a real pty: approve, the org picker, the email code with tab, tab to the email and back, deny + retry, expiry, esc and ctrl-c, an approval nobody collects (no session), a dropped connection, opening the browser, Clouds without it (nothing minted), the network warning and when the email goes out, the person-side refusals, and no secret in any log |
 
 `systemd-service.sh` exists because the service half cannot be tested on a
 developer machine without a password prompt, and a container gives real systemd
@@ -38,6 +39,13 @@ bash __tests__/e2e/layout/systemd-service.sh
 DASH=http://localhost:3000 MAILPIT=http://localhost:8026 OLD_CLOUD=http://localhost:28080 PG_CONTAINER=agenteye-postgres-1 \
   bash __tests__/e2e/layout/cli-login.sh
 
+# fp-login.sh drives the real `fp` the same way. STACK is the compose project, which
+# names the containers it reads. Add CLOUD_1090 and PG_1090 to cover a Cloud from
+# before `fp`'s half of this, and TRUSTED_DASH for the different-network warning. It
+# stops and restarts the dashboard container once.
+DASH=http://127.0.0.1:3000 MAILPIT=http://127.0.0.1:8026 STACK=agenteye \
+  bash __tests__/e2e/layout/fp-login.sh
+
 # cloud-collector.sh expects the stack on the remapped ports (18080/18123) so it
 # can run alongside an existing project rather than displacing it:
 docker compose -p aefpai -f docker-compose.yml -f ports.yml up -d

__tests__/e2e/layout/cli-login-driver.py

@@ -1,16 +1,18 @@
 #!/usr/bin/env python3
-"""Drive `failproofai config` through a real pseudo-terminal, screen by screen.
+"""Drive a login through a real pseudo-terminal, screen by screen.
 
-Used by cli-login.sh, inside the systemd container, as the unprivileged user.
-The wizard only offers browser login to a real terminal, so a pty is the only
-honest way to test it end to end.
+Used by cli-login.sh for `failproofai config` (inside the systemd container, as the
+unprivileged user) and by fp-login.sh for `fp login`. Both only offer browser login
+to a real terminal, so a pty is the only honest way to test it end to end.
 
 Usage: cli-login-driver.py <script> <transcript-file> <url-file> -- <command...>
 
 <script> is a comma-separated list of steps, each `wait:<text>` (block until
 the screen shows <text>), `key:<name>` (enter, down, up, esc, ctrl-c, tab),
-`url` (wait for the authorize link and write it to <url-file>), or
-`sleep:<seconds>`. Exit status is the command's own, or 124 on a timeout.
+`url` (wait for the authorize link and write it to <url-file>), `sleep:<seconds>`,
+`type:<text>`, or `typefile:<path>` (wait for that file, then type what it holds:
+for a value the script only learns later, like an emailed code). Exit status is
+the command's own, or 124 on a timeout.
 """
 import os
 import pty
@@ -83,6 +85,20 @@ def plain() -> str:
         elif kind == "key":
             time.sleep(0.3)  # let the screen settle so the key lands on it
             os.write(fd, KEYS[arg])
+        elif kind == "type":
+            time.sleep(0.3)
+            os.write(fd, arg.encode())
+        elif kind == "typefile":
+            # Not just "exists": the shell creates the file before it writes to it.
+            data = b""
+            while not data:
+                if os.path.exists(arg):
+                    with open(arg, "rb") as f:
+                        data = f.read().strip()
+                if not data and (time.time() > deadline or not pump(0.2)):
+                    print(f"driver: {arg} never appeared", file=sys.stderr)
+                    return 124
+            os.write(fd, data)
         elif kind == "sleep":
             end = time.time() + float(arg)
             while time.time() < end:

__tests__/e2e/layout/cli-login.sh

@@ -39,8 +39,10 @@ OUT=$(mktemp -d)
 PASS=0; FAIL=0
 ok()  { PASS=$((PASS+1)); printf '  \033[32mPASS\033[0m %s\n' "$1"; }
 bad() { FAIL=$((FAIL+1)); printf '  \033[31mFAIL\033[0m %s\n       %s\n' "$1" "${2:-}"; }
-has()   { if printf '%s' "$2" | grep -qF -- "$3"; then ok "$1"; else bad "$1" "missing [$3] in: $(printf '%s' "$2" | tr '\n' ' ' | tail -c 400)"; fi; }
-hasnt() { if printf '%s' "$2" | grep -qF -- "$3"; then bad "$1" "unexpected [$3]"; else ok "$1"; fi; }
+# Not `printf | grep -q`: on input bigger than a pipe buffer grep exits at the first match,
+# printf dies of SIGPIPE, and under pipefail a found string reads as a missing one.
+has()   { if [[ "$2" == *"$3"* ]]; then ok "$1"; else bad "$1" "missing [$3] in: $(printf '%s' "$2" | tr '\n' ' ' | tail -c 400)"; fi; }
+hasnt() { if [[ "$2" == *"$3"* ]]; then bad "$1" "unexpected [$3]"; else ok "$1"; fi; }
 eq()    { if [ "$2" = "$3" ]; then ok "$1"; else bad "$1" "want [$3] got [$2]"; fi; }
 head1() { printf '\n\033[1m── %s\033[0m\n' "$1"; }
 jqp() { python3 -c "import sys,json;d=json.load(sys.stdin);print(eval('d'+sys.argv[1]))" "$1" 2>/dev/null; }