Greatly simplify item API providers - #1315
Open
Robotgiggle wants to merge 4 commits into
Open
Robotgiggle wants to merge 4 commits into
Robotgiggle wants to merge 4 commits into
Conversation
Robotgiggle
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 1.21, Fabric now provides the
ItemApiLookupsystem for retrieving APIs from ItemStacks, and it works almost identically to the item capability system used on NeoForge. In fact, the two systems are so similar that there is no longer any need for platform-specific implementations of the various API interfaces in the commonaddldatapackage.This PR removes the platform-specific records implementing those interfaces, and changes the interfaces to either be records themselves (
ADHexHolder,ADPigment, andADVariantItem) or to provide nested record classes for their static and dynamic variants (ADIotaHolderandADMediaHolder).It also moves the definitions of the
ItemApiLookupobjects for each API provider to their own class (HexItemApiLookups) rather than defining them inHexCardinalComponents, as they have nothing to do with Cardinal Components. Together with the other refactoring, this should resolve #1165.