Fix #761: pad Smile async parser name quads like blocking parser - #765
Open
kalayciburak wants to merge 1 commit into
Open
Fix #761: pad Smile async parser name quads like blocking parser#765kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
…rser Unused high bytes of a partial name quad were left as zeros, so a short name collided with a longer NUL-prefixed one in the symbol table. Match SmileParser's 1s-padding on every partial quad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #761
The blocking
SmileParserpads unused high bytes of a partial name quad (_padQuadForNulls) so a short name cannot collide with a longer NUL-prefixed one inByteQuadsCanonicalizer(#312). The non-blocking parser still zero-padded those leftover bytes.Apply the same 1s-padding on every partial quad in:
NonBlockingParserBase._findDecodedFromSymbols(len < 5and theq2tail oflen < 9)NonBlockingParserBase._findDecodedLongerleftover 1-3 bytesNonBlockingByteArrayParser._finishLongFieldNameleftover 1-3 bytesTargeting
2.21as requested on the issue (bug is present there; merge-forward can carry it).Tests
../mvnw -Dtest=AsyncSymbolTable312Test test(RED before the change: async reported\"\\0\\0\\0a\"twice instead of\"\\0\\0\\0a\"then\"a\"; GREEN after)../mvnw -Dtest=AsyncSymbolTable312Test,SymbolTable312Test,AsyncParserNamesTest test: 12/0../mvnw testinsmile/: 267 tests, 4 skipped, 0 failures