[smile] Optimize async short ASCII string decoding - #767
Open
Dongnyoung wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes contiguous short-ASCII
VALUE_STRINGdecoding in the Smile async parser.NonBlockingByteArrayParserpreviously decoded these values by copying bytes intoTextBuffer's char buffer and then materializing aString. When the complete short ASCII value is already available in the input buffer, this PR constructs theStringdirectly from the input bytes usingStandardCharsets.US_ASCIIand resets theTextBufferwith that string.This mirrors the approach already used by the synchronous Smile parser for the equivalent contiguous short-ASCII path.
Changes
byte[]toStringdecoding for contiguous short ASCII values inNonBlockingByteArrayParserTextBufferstate withresetWithString(str)Benchmark
The benchmark exercises the actual async
NonBlockingByteArrayParserpath on JDK 21.0.7 using JMH 1.37.Setup:
ByteArrayFeeder.feedInput()callCHECK_SHARED_STRING_VALUESdisabledSmileConstants.MAX_SHORT_VALUE_STRING_BYTES)JsonParser.getString()JsonParser.getStringCharacters()Normalized allocation was effectively unchanged. The measured improvement therefore appears to come primarily from avoiding the intermediate byte-to-char decoding/copying step rather than from reducing allocation.
Testing
./mvnw -pl smile -Dtest=SimpleStringArrayTest -Dsurefire.useModulePath=false test