Repository navigation
test(server): guard the bucket boot warning against repeating - #512
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 3, 2026 07:56
![ferrfleet[bot]](https://avatars.githubusercontent.com/in/4354888?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No findings. announce_storage runs only from app(), so the count of 1 holds now. If someone moves the warning into backends, store() and app() would each emit it and the test fails, which is the regression it is meant to catch. Leaving out reclaim is fine: it goes through backends too, so adding it would cover nothing extra and would only make a network round trip to port 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #510
Review nit on #511:
boot_log.rsonly covered the access warning on a volume. This adds a bucket config and asserts "objects and locks are stored in a bucket" is logged once acrossstoreandapp. It fails on the code before #511 (2 occurrences) and passes now.