Skip to content

fix(tasks): separate completion from archive readiness - #1791

Draft
Marzx13 wants to merge 2 commits into
Fission-AI:mainfrom
Marzx13:codex/clarify-task-archive-readiness
Draft

fix(tasks): separate completion from archive readiness#1791
Marzx13 wants to merge 2 commits into
Fission-AI:mainfrom
Marzx13:codex/clarify-task-archive-readiness

Conversation

@Marzx13

@Marzx13 Marzx13 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

openspec instructions apply currently calls a change ready to archive when every tracked checkbox is checked. Task lists can also include archive-dependent work that cannot be completed beforehand, producing warnings in stock OpenSpec and a circular dependency under stricter project policies.

This PR reports tracked completion more precisely and helps avoid generating circular task lists. Follow-up work stays visible as ordinary bullets in the existing task document.

Closes #1790

Key changes

  • Replaces the archive-readiness claim with: "All tracked tasks are complete. Review or verify the change as appropriate before archiving."
  • Guides the default spec-driven task authoring flow toward work completable before archive, including hosted review or verification when appropriate.
  • Preserves requested archive and archive-dependent steps in an optional ## Workflow follow-up section at the end of tasks.md, with a plain-bullet example. These bullets are reference information outside tracked task progress.
  • Updates the shared apply instructions and committed generated skill, with regression coverage for output, unchanged JSON state/progress, per-tool command rewriting, and generated-template parity.

Testing performed

  • Build, lint, and TypeScript checks.
  • Revised guidance: 201 focused CLI, task parsing, task-guidance, command-reference, and template-parity tests passed across six files.
  • The follow-up example is checked with the existing task parser to confirm it adds no tracked tasks.
  • Original implementation: full local suite passed (4,343 tests; 79 skipped). Under npm 12, that run used a process-local npm_config_allow_git=all for the Git-dependency installation fixture; no persistent npm configuration was changed.
  • git diff --check.

Risks and follow-ups

The behavioral improvement depends on agents following the guidance; this does not enforce archive readiness or guarantee generated plans. Stock OpenSpec still permits archiving incomplete tasks after confirmation. Projects remain responsible for their archive policy and review-evidence requirements.

The all_done state, progress fields, task syntax and parsing, validation, and archive behavior remain unchanged. There are no dependency, migration, configuration-format, or schema-format changes. No changeset is included, following the normal release cadence unless a maintainer requests dedicated tracking.

AI assistance disclosure

Original research, implementation, and verification used OpenAI Codex with gpt-5.6-sol at xhigh reasoning effort. Subsequent review and revisions used OpenAI Codex with GPT-6 Astra.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify that completed tasks do not imply archive readiness

1 participant