Skip to content

fix: make warehouse connection test failures more visible - #8207

Open
Zaimwa9 wants to merge 1 commit into
mainfrom
fix/warehouse-test-error-red
Open

fix: make warehouse connection test failures more visible#8207
Zaimwa9 wants to merge 1 commit into
mainfrom
fix/warehouse-test-error-red

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #8112

The ClickHouse connection test failure banner now:

  • uses error styling (red) instead of a warning
  • spans the full form width
  • puts the "You can save anyway…" hint on its own line

How did you test this code?

Manually against a ClickHouse Cloud instance, triggering each failure detail (unreachable host, wrong port, bad credentials, missing database, missing events table, internal host) plus the success path. Unit tests updated for the new line break.

Show test failures with error styling instead of a warning, stretch the
banner to full width, and put the save-anyway hint on its own line.
@Zaimwa9
Zaimwa9 requested a review from a team as a code owner August 3, 2026 09:57
@Zaimwa9
Zaimwa9 requested review from talissoncosta and removed request for a team August 3, 2026 09:57
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Aug 3, 2026 9:58am
flagsmith-frontend-staging Ready Ready Preview Aug 3, 2026 9:58am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Aug 3, 2026 9:58am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 94241677-c9ad-4535-b826-0ab7b0e42882

📥 Commits

Reviewing files that changed from the base of the PR and between fc33002 and 63ef50e.

📒 Files selected for processing (4)
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ClickHouseConfigForm.tsx
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/ConfigForm.scss
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/warehouseFormUtils.test.ts
  • frontend/web/components/pages/environment-settings/tabs/warehouse-tab/warehouseFormUtils.ts

📝 Walkthrough

Walkthrough

The warehouse connection test now renders failures through ErrorMessage with error styling. The form preserves line breaks in failure text. getTestFailureWarning places save guidance on a separate line. Tests cover missing-table and general connection failures.

Estimated code review effort: 2 (Simple) | ~10 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8207 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8207 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-8207 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-8207 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8207 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-8207 Finished ✅ Results

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #18943 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 2 seconds
commit  63ef50e
info  🔄 Run: #18943 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #18943 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  32 seconds
commit  63ef50e
info  🔄 Run: #18943 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #18943 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.6 seconds
commit  63ef50e
info  🔄 Run: #18943 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #18943 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.5 seconds
commit  63ef50e
info  🔄 Run: #18943 (attempt 1)

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants