Repository navigation
Ship the 8 + 3 tables with setup; fix the cache preflight and quality slider (0.2.0) - #62
Merged
Merged
Conversation
…che preflight Setup always installs the four three-step refinement tables (332 MiB), so the default 8 + 3 works offline, and new installations prepare every quality level by default. Existing installations keep their choice. Cache preflight: fetch the tables the encoder will select for reference audio (not image-to-video tables), download files in parallel with the sources ranked at setup instead of a new speed test per request, set aside a damaged shared copy instead of blocking every request, check free space, and keep the ComfyUI console quiet. The engine reads each table file from whichever folder holds it, so a table split between folders is never downloaded again. Quality slider: each level is a complete plan. Editing first-pass steps turns two-pass off only for committed values and restores it at 8; opening the studio no longer rewrites a workflow; saved 8 + 2 workflows move to 8 + 3 once; Chinese level names; estimates also work on Macs. Diagnostics keep the optional table counters. Release 0.2.0.
…fer on cancel - Ctrl+Enter leaves focus in a field: commit its edit before queuing, so the queued plan matches the editor. One first-pass step is accepted once the two-pass rule has turned two-pass off. - A cancel reaches one download worker; stop the others at once instead of waiting for earlier transfers in order. - Add tables only for reused caches whose weights match the published ones. - The CLI and the ComfyUI setup panel prepare every level for new installations and keep an existing installation's choice, like the launcher.
Every quality level is nine hundred small files. Setup sent each through a large-model transfer process, two at a time, so the tables took about half an hour on a fast connection. Fetch them six at a time with the request preflight's verified resumable transfers; receipts, the ledger and progress are unchanged, and large model files keep their two-slot pipeline.
The frozen launcher clears PyInstaller's DLL directory while it starts an external process. Parallel source probes overlapped those windows and could restore an empty directory, breaking later DLL loads in the launcher. Clear it for the first caller and restore it after the last.
Engine processes receive FREEVIDEO_HOME only, so paths.model_root() meant models/ while setup and the request preflight write to the recorded model folder (models/vdn). The engine therefore never used installed or preflighted sampling tables and downloaded each one again during the timed run, and new installations downloaded the 690 MB latent upscaler a second time on their first two-pass generation. Resolve the recorded folder for both; a copy an earlier version downloaded under models/ stays in use.
The two-pass rule runs on committed values, before validation; a single custom step reads 1 step, not 1 steps.
With "Prepare all quality levels" on, the launcher treated the installation as unfinished and sent every update or launch back to the setup review, asking to accept a 0 GiB plan again. New installations now have the option on by default, so check the files instead: set up again only while a requested level is missing (or no published table applies to these weights).
KBRASK
force-pushed
the
fix/quality-levels-followup
branch
from
October 5, 2026 23:23
1fbd9ca to
edee0c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60 after review and testing on Windows. Builds on #61 (the first-generation fix and the launcher wordmark), so merge #61 first.
Default 8 + 3 works out of the box
--no-sampling-cachesopts out.Installed files are actually used
paths.model_root()meantmodels/, while setup and the request preflight write to the recorded model folder (models/vdn). The engine therefore never used installed or preflighted sampling tables. It downloaded each one again during the timed run, so "Prepare all quality levels" saved nothing. New installations also downloaded the 690 MB latent upscaler a second time on their first two-pass generation.models/stays in use.Cache preflight before a request
Quality slider
Other
Checked