Repository navigation
Offer to add workflows to earlier videos, with backups (0.2.3) - #70
Merged
Merged
Conversation
Videos made before v0.2.2 keep their workflow only in workflow.json. Creations
now offers to add it to them, with the number of videos and the space their
backups take, and nothing changes until the user confirms ("Don't ask again"
is remembered).
Each video is skipped unless it is safe to rewrite: its workflow.json must
hold a canvas workflow, the request must have finished, there must be room for
a copy plus 512 MiB, it must have only audio and video streams, and no earlier
backup may exist. The rewrite replaces the original only after every packet of
every stream matches it byte for byte and the workflow reads back. The original
is kept as video.before-workflow.mp4, and the result cache is updated so saved
results stay reusable. New videos get the same check, and sharing exports
ignore an empty workflow.json.
Release 0.2.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.
Videos made before v0.2.2 keep their workflow only in
workflow.json. This offers to add it to them, safely and only when the user asks. Release 0.2.3.Asked first
--disable-metadatahides the offer.Changes nothing it cannot verify
workflow.jsonhas no canvas workflow (requests queued through the API save an empty one);video.before-workflow.mp4: a hard link, or a size-checked copy.workflow.json.Checks