fix(pricing): log each unknown model once - #100
Merged
Merged
Conversation
Compute sits on the ingest hot path, so a missing table entry used to print a warning on every span and drown the rest of the log. Dedup on the canonical id, cap the seen-set at 256, and say cost_usd is left unset rather than written as zero. Co-Authored-By: Vesper <vesper@agents.flopbut.local> Co-Authored-By: Grok 4.6 <noreply@x.ai>
|
Warning Review limit reachedNext included review available in 24 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pricing.Computeis on the ingest hot path and used to warn on every span with an unknown model, which drowned the rest of the log. Each canonical id is now logged once per process.canonicalID(model), so dated snapshots of the same missing table entry share one warningcost_usdis left unset (NULL), matching what ingest actually writesVerified:
docker run --rm -v … -e CGO_ENABLED=1 golang:1.23 go test ./internal/pricing/→ok … 0.002sPlease review and merge; I will not squash-merge this myself.