Skip to content

Bind replacement intake to exact checker-remediation evidence - #537

Open
Abiorh001 wants to merge 50 commits into
mainfrom
codex/arch-04f3-integration
Open

Abiorh001 wants to merge 50 commits into
mainfrom
codex/arch-04f3-integration

Conversation

@Abiorh001

@Abiorh001 Abiorh001 commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator

Change

ARCH-04F3 — Bind replacement ZIP intake to the exact authorized checker failure.

A contributor can replace a failed Submission only after its current checker result produces the authorized remediation outcome. The changed ZIP passes full intake again before the existing atomic writer creates the successor Submission and evaluation request.

Intent And Planning Context

The bounded change record defines allowed files, alternatives, acceptance criteria and remaining boundaries.

What Changed

  • Compose TASK assignment/predecessor facts with the CHECKERS current-result port.
  • Bind the server-selected remediation reference through ART evidence/admission, AUTH resources and immutable Submission dispatch.
  • Replace the ambiguous creation kind with checker_remediation and update affected callers and tests together.
  • Preserve initial receipts during migration; refuse retained replacements whose cause cannot be proven without inventing or deleting data.
  • Reconcile current navigation and retain main’s CLI guide-activation delivery.

Design And Scope

This extends the existing context port, intake and atomic writer. It adds no parallel replacement path. The change remains hidden: public intake, production registration, human review runtime, claim timers and payment delivery are separate work. All changed files are covered by the record.

Evidence

Final head: af33a9e711fe6a47f3e93549d991f0289b20b712.

Backend run 38153685918 and all other required checks passed. Hosted merge 497a3bc1e has the exact same tree as the PR head.

  • 9,173 unique tests collected and completed, zero skipped/deselected, duplicated or missing.
  • All ten semantic lanes and real API checks passed. Independent canonical evidence validation passed; database and MinIO cleanup and evidence digests were verified.
  • Real PostgreSQL proofs cover exact cause binding, stale-evidence denial, deferred dispatch rollback, competing replacements, actual outbox-insert rollback, changed-ZIP intake and replay under both review-policy modes.
  • Three guard-removal probes detect missing attempt/cause reconstruction, evidence currentness and deferred dispatch currentness.
  • Focused integration, history/privacy and migration preservation/refusal checks passed. The contribution-migration test now targets its own revision and preserves its downgrade-refusal assertion.
  • Ruff, module/AUTH/test-structure boundaries, ownership/lane inventory, Commitrail, markdown links and stale-wording checks passed.

Hosted wall time was approximately 23m40s; the advisory timing target was missed. Coverage remains diagnostic, not a gate.

Test Delta And CI Integrity

Obsolete synthetic replacement fixtures now use real authorized routing outcomes. Initial intake, archive-change, ownership, locked-policy, privacy, history and preservation assertions remain. No skips, gate weakening, workflow changes or compatibility aliases were introduced.

Impact-Routed Reviews

Security, architecture/reuse, QA/test-delta and documentation/product-operations: PASS AFTER FIXES, no open findings. Product-source review is bound to f026f1bda; subsequent changes were the migration-test correction and main’s CLI integration. Narrow QA/test-delta passed at 87b5f75a5; final integration/documentation compatibility and CI-integrity review passed at af33a9e71. Earlier runtime evidence is explicitly source-compatible, while hosted completeness is exact-tree evidence.

External Review

CodeRabbit is rate-limited after this PR became ready for review; it supplied no substantive review. There are no unresolved review threads. Eligible human approval is still required.

Remaining Work And Human Focus

Infrastructure retry is a separate stacked PR. Manager-visible setup-fault holds, production wiring, public intake and the first contributor drill remain. The migration deliberately refuses unprovable retained replacements.

Inspect failure currentness at every intake/consumption boundary, immutable predecessor/evidence custody, fresh-authority replay and atomic rollback across ART/TASK/AUTH/CHECKERS/outbox.

Human Merge Ownership

  • Eligible human approval on the final checked head.
  • Explicit user approval to merge this specific PR.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7b86ad6e-4cdf-45ef-8737-f651900de184

📥 Commits

Reviewing files that changed from the base of the PR and between e31e177 and af33a9e.


📒 Files selected for processing (81)
  • .ci/behavior-ownership/partition.v1.json
  • .commitrail/INDEX.md
  • .commitrail/initiatives/WS-ARCH-001/OVERVIEW.md
  • .commitrail/initiatives/WS-ARCH-001/WS-ARCH-001-04F3.md
  • .commitrail/initiatives/WS-ARCH-001/planning/CHUNK_MAP.md
  • .commitrail/initiatives/WS-ARCH-001/planning/PLAN.md
  • .commitrail/initiatives/WS-ARCH-001/planning/chunks/WS-ARCH-001-04F-checker-remediation.md
  • .commitrail/initiatives/WS-ART-001/OVERVIEW.md
  • .commitrail/initiatives/WS-AUTH-001/OVERVIEW.md
  • .commitrail/initiatives/WS-AUTH-001/planning/CHUNK_MAP.md
  • .commitrail/initiatives/WS-AUTH-001/planning/PLAN.md
  • .commitrail/initiatives/WS-CON-001/OVERVIEW.md
  • .commitrail/initiatives/WS-POL-003/OVERVIEW.md
  • .commitrail/initiatives/WS-POL-003/planning/CHUNK_MAP.md
  • .commitrail/initiatives/WS-POL-003/planning/PLAN.md
  • .commitrail/initiatives/WS-REV-001/OVERVIEW.md
  • README.md
  • backend/alembic/env.py
  • backend/alembic/versions/0034_checker_remediation_replacement.py
  • backend/app/adapters/tasks/__init__.py
  • backend/app/modules/artifacts/models.py
  • backend/app/modules/artifacts/pre_submit_evidence.py
  • backend/app/modules/artifacts/schemas.py
  • backend/app/modules/artifacts/service.py
  • backend/app/modules/artifacts/submission_admission.py
  • backend/app/modules/artifacts/submission_bindings.py
  • backend/app/modules/artifacts/submission_materialization.py
  • backend/app/modules/authorization/submission_consumption.py
  • backend/app/modules/authorization/submission_creation_authorization.py
  • backend/app/modules/authorization/submission_preparation.py
  • backend/app/modules/tasks/api/submission_context.py
  • backend/app/modules/tasks/models.py
  • backend/app/modules/tasks/repository.py
  • backend/app/modules/tasks/submission_composition.py
  • backend/app/modules/tasks/submission_context.py
  • backend/app/modules/tasks/submission_replay.py
  • backend/scripts/behavior_ownership.py
  • backend/scripts/test_lane_catalogue.py
  • backend/tests/authorization/submission_history/test_isolation.py
  • backend/tests/authorization/task_authority/test_lifecycle_races.py
  • backend/tests/authorization/task_authority/test_submission_policy.py
  • backend/tests/conftest.py
  • backend/tests/historical_submission_fixtures.py
  • backend/tests/migration_fixtures.py
  • backend/tests/migrations/test_contribution_read_audit.py
  • backend/tests/pre_submit_test_helpers.py
  • backend/tests/retained_material_fixtures.py
  • backend/tests/reviews/decision/support.py
  • backend/tests/submission_fixtures.py
  • backend/tests/tasks/post_submit_routing/support.py
  • backend/tests/tasks/post_submit_routing/test_evaluation_guard.py
  • backend/tests/tasks/post_submit_routing/test_remediation_migration.py
  • backend/tests/tasks/post_submit_routing/test_requests.py
  • backend/tests/tasks/post_submit_routing/test_source_preparation.py
  • backend/tests/tasks/submission_dispatch/test_migration.py
  • backend/tests/tasks/submission_dispatch/test_replacement_creation.py
  • backend/tests/tasks/submission_dispatch/test_replacement_migration.py
  • backend/tests/test_alembic.py
  • backend/tests/test_approved_guide_intake.py
  • backend/tests/test_artifact_bindings.py
  • backend/tests/test_artifact_bindings_db.py
  • backend/tests/test_behavior_ownership.py
  • backend/tests/test_blocked_pre_submit_feedback_postgresql.py
  • backend/tests/test_ci_lane_catalogue.py
  • backend/tests/test_effective_pre_submit_execution.py
  • backend/tests/test_pre_submit_attempt_schema.py
  • backend/tests/test_submission_bundle_admission.py
  • backend/tests/test_submission_bundle_preparation_recovery.py
  • backend/tests/test_submission_composition.py
  • backend/tests/test_submission_evaluation_capacity.py
  • backend/tests/test_submission_predecessor_custody.py
  • backend/tests/test_tasks.py
  • docs/architecture_data_model.md
  • docs/architecture_lifecycle_state_machine.md
  • docs/operations_queue_policy.md
  • docs/operations_revision_replay.md
  • docs/roadmap_status.md
  • docs/spec_artifact_storage_service.md
  • docs/spec_authorization_service.md
  • docs/spec_chunk_4_task_queue_assignment.md
  • docs/spec_review_lifecycle.md

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Commitrail Probe added 21 commits October 11, 2026 15:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant