Repository navigation
Conversation
The floor denies /dev on every host. On a host without a device tree that path is \dev, which names no root of its own, so no check can canonicalize it and the floor cannot be built: AgentFloor is made of those roots, so the agent plugin is not created at all and everything that starts the runtime fails on such a host. The device tree is a root where there is one, so it is denied where the host separates paths with a slash and nowhere else.
Collaborator
Author
|
Superseded by the branch that now holds every fix of this kind: \ix/platform, which carries this fix and the write-permission one, both rebased onto the current \master. The commit that was here is the first of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a host without a device tree the floor cannot be built, so the agent plugin is not created and everything that starts the runtime fails.
What happens
standardRootsdeniesPath.of("/dev")on every host. On Windows that path is\dev, which names no root of its own —Files.isAbsoluteis false — so canonicalizing it is refused:AgentFlooris built from those roots, so a suite that starts the runtime fails before a test runs:In the checkout this was found in, 265 of the 658 tests of
:libraries:agent:testfail this way. The message names the floor rather than the platform, so the cause is not visible from the failures themselves.The change
The device tree is a root where there is one, so it is denied where the host separates paths with
/and nowhere else. Nothing else ofstandardRootschanges: the credential stores are under the home directory, and the moved stores come from the environment.Verification
:libraries:internal:compileKotlinand:libraries:internal:spotlessCheckpass on this branch.Found while adding a channel for OneBot. The floor is not that channel's, but no channel can run the agent plugin on such a host until this is fixed.